aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Nathaniel Manista <nathaniel@google.com>2017-02-15 22:09:16 +0000
committerGravatar Nathaniel Manista <nathaniel@google.com>2017-02-15 22:09:16 +0000
commit3577f63136e1f1d6e26a00176a0cff6d9b2d9934 (patch)
treeb3ee19ed96eb4cbb76f02662c1f035e54add0da8
parent4ead91a9145f6a255c4f72324254bac8b4d4f45b (diff)
Fix and enable logging-format-interpolation lint
-rw-r--r--.pylintrc3
-rw-r--r--src/python/grpcio/grpc/_common.py2
2 files changed, 2 insertions, 3 deletions
diff --git a/.pylintrc b/.pylintrc
index a4f757f9bd..23375149c7 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -32,7 +32,6 @@
#TODO: Enable simplifiable-if-statement
#TODO: Enable no-self-use
#TODO: Enable no-member
-#TODO: Enable logging-format-interpolation
#TODO: Enable dangerous-default-value
-disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,no-value-for-parameter,cyclic-import,unused-variable,redefined-outer-name,unused-import,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called,simplifiable-if-statement,no-self-use,no-member,logging-format-interpolation,dangerous-default-value
+disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,no-value-for-parameter,cyclic-import,unused-variable,redefined-outer-name,unused-import,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called,simplifiable-if-statement,no-self-use,no-member,dangerous-default-value
diff --git a/src/python/grpcio/grpc/_common.py b/src/python/grpcio/grpc/_common.py
index a5f1f38ea9..dd74ba3ab6 100644
--- a/src/python/grpcio/grpc/_common.py
+++ b/src/python/grpcio/grpc/_common.py
@@ -92,7 +92,7 @@ def decode(b):
try:
return b.decode('utf8')
except UnicodeDecodeError:
- logging.exception('Invalid encoding on {}'.format(b))
+ logging.exception('Invalid encoding on %s', b)
return b.decode('latin1')