aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar David G. Quintas <dgq@google.com>2017-01-23 09:24:11 -0800
committerGravatar GitHub <noreply@github.com>2017-01-23 09:24:11 -0800
commit2e36be09af75e69b363da783a8df181b4a446699 (patch)
tree02493ddf51f2258b8e9f9484898f649c072ccce7
parentba9aa59bdfc107054dd6083f36b3527a9bc85d72 (diff)
Revert "Fix cronet header memory free"
-rw-r--r--src/core/ext/transport/cronet/transport/cronet_transport.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/core/ext/transport/cronet/transport/cronet_transport.c b/src/core/ext/transport/cronet/transport/cronet_transport.c
index 419bfb7b7d..025ae30df2 100644
--- a/src/core/ext/transport/cronet/transport/cronet_transport.c
+++ b/src/core/ext/transport/cronet/transport/cronet_transport.c
@@ -655,6 +655,8 @@ static void convert_metadata_to_cronet_headers(
headers[num_headers].key = key;
headers[num_headers].value = value;
num_headers++;
+ gpr_free(key);
+ gpr_free(value);
if (curr == NULL) {
break;
}
@@ -855,12 +857,6 @@ static enum e_op_result execute_stream_op(grpc_exec_ctx *exec_ctx,
s->header_array.capacity = s->header_array.count;
CRONET_LOG(GPR_DEBUG, "bidirectional_stream_start(%p, %s)", s->cbs, url);
bidirectional_stream_start(s->cbs, url, 0, method, &s->header_array, false);
- unsigned int header_index;
- for (header_index = 0; header_index < s->header_array.count;
- header_index++) {
- gpr_free((void *)s->header_array.headers[header_index].key);
- gpr_free((void *)s->header_array.headers[header_index].value);
- }
stream_state->state_op_done[OP_SEND_INITIAL_METADATA] = true;
result = ACTION_TAKEN_WITH_CALLBACK;
} else if (stream_op->recv_initial_metadata &&