diff options
| author |  David Garcia Quintas <dgq@google.com> | 2016-09-28 09:50:23 -0700 |
|---|---|---|
| committer | David Garcia Quintas <dgq@google.com> | 2016-09-28 09:54:08 -0700 |
| commit | 129bb463c31c287a1ea8565ea3fa99c97c9aac7c (patch) | |
| tree | 24eb041d7e86d78b94d0b26bf1a74c078a96baff | |
| parent | 7ab8eecdc9c0c2b1ebb2e69d7460bebca774ebd9 (diff) | |
Added comments wrt lb/subchannel args ownership.
| -rw-r--r-- | src/core/ext/lb_policy/pick_first/pick_first.c | 2 | ||||
| -rw-r--r-- | src/core/ext/lb_policy/round_robin/round_robin.c | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/core/ext/lb_policy/pick_first/pick_first.c b/src/core/ext/lb_policy/pick_first/pick_first.c index 466a0fdede..5af484eccf 100644 --- a/src/core/ext/lb_policy/pick_first/pick_first.c +++ b/src/core/ext/lb_policy/pick_first/pick_first.c @@ -466,6 +466,8 @@ static grpc_lb_policy *create_pick_first(grpc_exec_ctx *exec_ctx, } memset(&sc_args, 0, sizeof(grpc_subchannel_args)); + /* server_name will be copied as part of the subchannel creation. This makes + * the copying of args->server_name (a borrowed pointer) OK. */ sc_args.server_name = args->server_name; sc_args.addr = (struct sockaddr *)(&args->addresses->addresses[i].address.addr); diff --git a/src/core/ext/lb_policy/round_robin/round_robin.c b/src/core/ext/lb_policy/round_robin/round_robin.c index 037f180a9e..dfd4b1929c 100644 --- a/src/core/ext/lb_policy/round_robin/round_robin.c +++ b/src/core/ext/lb_policy/round_robin/round_robin.c @@ -629,6 +629,8 @@ static grpc_lb_policy *round_robin_create(grpc_exec_ctx *exec_ctx, if (args->addresses->addresses[i].is_balancer) continue; memset(&sc_args, 0, sizeof(grpc_subchannel_args)); + /* server_name will be copied as part of the subchannel creation. This makes + * the copying of args->server_name (a borrowed pointer) OK. */ sc_args.server_name = args->server_name; sc_args.addr = (struct sockaddr *)(&args->addresses->addresses[i].address.addr); |