aboutsummaryrefslogtreecommitdiffhomepage
path: root/.pylintrc
diff options
context:
space:
mode:
authorGravatar Nathaniel Manista <nathaniel@google.com>2017-02-24 17:47:24 +0000
committerGravatar Nathaniel Manista <nathaniel@google.com>2017-03-02 21:39:51 +0000
commite151a21ee4912c1ce4ba021a029b9d190ce2d254 (patch)
treecb7cc5cc3cb38fbbf518915a9d4ca402fbfeb610 /.pylintrc
parent7983213fd2831e36e532d54b75fb879ba5fee084 (diff)
Fix and enable unused-variable lint
In _server.py start_server_batch_result is removed because start_server_batch can only ever fail as a result of a programming defect in gRPC Python and not the application. This differs from some analogous-appearing points in _channel.py where the result of start_client_batch is checked because at those points it is possible for a failure to indicate a programming defect on the part of the application.
Diffstat (limited to '.pylintrc')
-rw-r--r--.pylintrc8
1 files changed, 6 insertions, 2 deletions
diff --git a/.pylintrc b/.pylintrc
index 5ccfad7fc0..f7cf0588ac 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -1,3 +1,8 @@
+[VARIABLES]
+# TODO(https://github.com/PyCQA/pylint/issues/1345): How does the inspection
+# not include "unused_" and "ignored_" by default?
+dummy-variables-rgx=^ignored_|^unused_
+
[MESSAGES CONTROL]
#TODO: Enable missing-docstring
@@ -15,7 +20,6 @@
#TODO: Enable wrong-import-order
#TODO: Enable no-value-for-parameter
#TODO: Enable cyclic-import
-#TODO: Enable unused-variable
#TODO: Enable redefined-outer-name
#TODO: Enable too-many-instance-attributes
#TODO: Enable broad-except
@@ -29,4 +33,4 @@
#TODO: Enable too-many-nested-blocks
#TODO: Enable super-init-not-called
-disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,no-value-for-parameter,cyclic-import,unused-variable,redefined-outer-name,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called
+disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,no-value-for-parameter,cyclic-import,redefined-outer-name,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called