| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In https://crbug.com/747643, a new version of Clang produces warnings
when attempting to format NSInteger as %zd (which is normally used for
ssize_t). Acquiesce by casting NSInteger to long and formatting using
%ld.
In the process, I audited all occurrences of %zd in GTM and found that
the remainder were being used to format size_t, which ought to use %zu,
so I’ve corrected those.
I also audited the existing uses of %zu and found them all to be
correct.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of code that Google stopped using/maintaining rather than trying
to update it it. Some would be hard to update, some actually has system provided
replacements; others are patterns that just don't seem as common now.
Prune out the code related to macOS <= 10.5, start pruning some of the really
old iOS support also.
Get the projects mostly limping again with modern Xcodes so tests can be run.
If someone ends up on this commit via history for something they still find
as useful, feel free to do a pull request to bring the snippet of code back to
life and update it for current SDKs.
|
| |
|
| |
|
|
|
|
|
|
| |
- Update URL
- Add README.md/License/Contributing info to be up to spec.
- Remove a bunch of executable bits on sources.
|
| |
|
|
|
|
| |
DELTA=1 (0 added, 0 deleted, 1 changed)
DELTA_BY_EXTENSION=m=1
|
|
|
|
|
|
|
|
| |
The iOS 7 APIs for drawing strings require NSDictionary parameters
so make sure there's no way to insert a nil value when creating the
dictionaries or the app will crash.
DELTA=35 (10 added, 0 deleted, 25 changed)
DELTA_BY_EXTENSION=m=35
|
|
|
|
|
|
| |
black.
DELTA=16 (14 added, 1 deleted, 1 changed)
DELTA_BY_EXTENSION=m=15
|
|
|
|
| |
DELTA=35 (34 added, 0 deleted, 1 changed)
DELTA_BY_EXTENSION=m=35
|
|
|
|
|
|
|
|
| |
When building for arm64, NSInteger is a 64-bit value. Recommendations
are to either use "%ld" and cast the value to long or to use "%zd".
This patch uses "%zd" that work on both armv7 and arm64 as it avoid
doing a cast.
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
| |
NSLineBreakByClipping, instead of UILineBreakModeClip.
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
| |
DELTA=7 (0 added, 0 deleted, 7 changed)
|
|
|
|
|
|
|
|
|
| |
development. Resolve a large collection of warnings generated by turning on SUSPICIOUS_IMPLICIT_CONVERSIONS which included the three warnings but also apparently extras.
QA:
No change should be observed.
TESTED=tests still pass
DELTA=155 (48 added, 61 deleted, 46 changed)
|
|
|
|
|
|
|
|
| |
Remove the GC support code.
Add the needed images for the iOS unittests under iOS 6.0.
Add a workspace file for the iPhone project.
R=dmaclach
DELTA=215 (85 added, 122 deleted, 8 changed)
|
|
|
|
|
|
|
|
|
| |
Add a comment explaining that this file is similar to something that Apple has now built in.
Tested:
n/a
R=thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
| |
Fix up string to match. Probably a stray delete we missed.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Clean up all of our format string issues amongst some other fun stuff.
R=thomasvl
DELTA=167 (90 added, 8 deleted, 69 changed)
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes two things on the GTMFadeTruncatingLabel:
* The class now respects the linebreak mode set on the superclass property (but still defaults to UILineBreakModeClip).
* The API to create the fading mask is exposed as a class method so it can be
reused outside in other contexts with the same display.
R=thomasvl
APPROVED=thomasvl
DELTA=22 (13 added, 1 deleted, 8 changed)
|
|
|
|
|
|
|
| |
Add reference images for iOS 5 since the text rendering metrics have
changed enough to break the test otherwise.
R=dmaclach
DELTA=35 (35 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move a bunch of tests over onto the GTM test base class.
Fetch some test images from the bundle the test is compiled into instead
of assuming main app.
Change the default iOS logging directory to just be the documents directory
since it should work for all iOS versions.
Add initial support for using SenTestingKit instead of our custom version
to allow the Xcode 4 UI for unittesting.
Add a target for using SenTestingKit.
Add a shell app for the TEST_HOST for SenTestingKit usage (since there are
UI tests, we need to use a real app and not the octest binary).
R=dmaclach
DELTA=517 (482 added, 9 deleted, 26 changed)
|
|
|
|
|
|
| |
Follow dmaclach review -> style changes.
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
|
|
|
| |
Handle UIButton in GTMUILocalizer
To be noted: UISegmented Controls and UISearchBars were alredy
working. UISwitch doesn't have any strings to be localized.
R=dmaclach,thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix memory model by making all the outlets assign not retain.
The problem here is UIViewControllers will dump their view in low memory
and then reload next time it is needed. So someone hangs on to the
localizer for something else, it would keep the views also loaded, so this
way the localizer won't keep any of the objects it points to alive via a
retain. Note: the AppKit version sorta matches this since outlets aren't
retained by default.
Clear them in awakeFromNib since that is all they are needed for.
R=dmaclach
DELTA=19 (9 added, 0 deleted, 10 changed)
|
|
|
|
|
|
|
| |
Some quick comment cleanup.
Quick switch over to properties.
R=dmaclach
DELTA=38 (9 added, 14 deleted, 15 changed)
|
|
|
|
|
|
|
|
|
| |
Implements GTMUILocalizer for iOS.
The interface is exactly the same, the implementation does walk the UIKit view
hierarchy, instead of the Cocoa one.
R=thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
| |
Add text shadow support to GTMFadeTruncatingLabel
R=thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
|
| |
Fade to translucent mask used by chrome instead of an ellipses or just truncating the string.
R=dmaclach
APPROVED=dmaclach
DELTA=249 (249 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Wrap the header so it compiles right if included in a C++ file.
R=dmaclach
DELTA=6 (6 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Removed iPhone/GTMABAddressBook in favor of AddressBook/GTMABAddressBook.
Removed Foundation/GTMHTTPServer and UnitTesting/GTMTestHTTPServer, they
are going to go live with the fetcher used by GData (since they were done
for that testing).
Removed Foundation/GTMBase64 and Foundation/GTMNSData+Hex in favor of
Foundation/GTMStringEncoding.
R=dmaclach
DELTA=5118 (13 added, 5105 deleted, 0 changed)
|
|
|
|
|
|
| |
Adds necessary imports in case somebody wants to use GTM without precompiled headers.
R=dmaclach
DELTA=5 (5 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Turns on the undeclared-selector warning. This may cause builds to fail if they are using
our configs. Also cleaned up some whitespace issues.
R=thomasvl
DELTA=94 (71 added, 22 deleted, 1 changed)
|
|
|
|
|
|
|
| |
UIImage rotate method plus tests.
R=altse
APPROVED=altse
DELTA=152 (152 added, 0 deleted, 0 changed)
|
|
|
|
|
| |
Makes the rounded rect calls fit the CG calling conventions.
R=thomasvl
|
|
|
|
|
|
| |
Add GTMRoundedRectPath to draw rounded rectangles on iPhone.
R=thomasvl
DELTA=72 (72 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
| |
subtreeDescription is a debugging tool for displaying UIView hierarchies in the Xcode Console window in DEBUG builds.
As it says in the .h file:
pause in the debugger and type something like:
(gdb) po [[[UIApplication sharedApplication] keyWindow] subtreeDescription]
and a nicely pretty printed version of the view hierarchy will be printed in the debugger console window.
DELTA=179 (179 added, 0 deleted, 0 changed)
R=dmaclach,mikemorton,thomasvl
|
|
|
|
|
|
|
| |
Use UIImage drawing methods rather than CGContext. This respects the
UIImageOrientation unlike CGContext.
R=thomasvl
DELTA=21 (0 added, 14 deleted, 7 changed)
|
|
|
|
|
|
| |
Correct over-release on error of an autoreleased object. Thanks to Mike Morton for reporting this.
DELTA=2 (0 added, 2 deleted, 0 changed)
R=thomasvl,dmaclach
|
|
|
|
|
|
|
| |
Add category extension to UIImage to allow resizing while preserving aspect
ratios and optional image clipping.
R=thomasvl,dmaclach
DELTA=507 (507 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
|
| |
in log validation.
- Added GTM_SUPPORT_GC for controlling the inclusion of GC related code.
- If you are using GTMUnitTestDevLog, it also tries to capture logs from
NSAssert.
- Added GTM_FOREACH_OBJECT/GTM_FOREACH_KEY that uses NSEnumerator and
objectEnumerator/keyEnumerator on 10.4, but on 10.5+/iPhone uses
FastEnumeration.
- GTMNSWorkspace+Running gives a variety of ways of determining the attributes
of running processes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stack.
- Added GTM_EXTERN that makes it easier to mix and match objc and objc++ code.
- Added GTMHotKeysTextField for display and editing of hot key settings.
- Added GTMCarbonEvent for dealing with Carbon Events and HotKeys in a ObjC like way.
- Backported the Atomic Barrier Swap functions for Objective C back to Tiger.
- Added a variety of new functions to GTMUnitTestingUtilities for checking if the screensaver is in the way, waiting on user events, and generating keystrokes.
- If you are using any Carbon routines that log (DebugStr, AssertMacros.h) and use GTMUnitTestDevLog, the log routines now go through _GTMDevLog so that they can be caught in GTMUnitTestDevLog and verified like any _GTMDevLog calls you may make. For an example of this in action see GTMCarbonEventTest.m.
- Added GTMFileSystemKQueue. It provides a simple wrapper for kqueuing something in the file system and tracking changes to it.
- RunIPhoneUnitTest.sh now cleans up the user home directory and creates a documents directory within it, used when requesting a NSDocumentDirectory.
- Added GTMNSFileManager+Carbon which contains routines for path <-> Alias conversion and path <-> FSRef conversion.
- Added GTMNSArray+Merge for merging one array into another with or without a custom merging function, returning a new array with the merged contents.
|
|
|
|
|
|
|
|
|
| |
GTMNSAppleScript+Handler.
- GTMStackTrace support for building a trace from the call stack in an NSException (for 10.5+ and iPhone).
- Added GTMUIFont+LineHeight.
- Cleaned up some OS version checks to use constants instead of numbers directly.
|
|
|
|
|
| |
- Fix for issue 7 GTMABMutableMultiValue instantiation returns nil.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
way for all GTM code to do it.
- Added GTMDebugThreadValidation to allow you to enforce the fact that your
code must run in the main thread in DEBUG builds.
- Updated some internals of the iPhone unittesting so it doesn't double print
the test descriptions, file names, or lines numbers of a test failure line.
Also includes the test names in the error output.
- Changed the xcconfigs so that know it's easier to set different settings at
the different levels and not accidentally overwrite settings set at lower
levels in the "settings collapse". Also tightened up warnings significantly.
- Changed how gtm_unitTestExposedBindingsTestValues works. If you have an
implementation of gtm_unitTestExposedBindingsTestValues in your own code
you will need to update to the new way of calling. See implementations in
GTMNSObject+BindingUnitTesting.m for details.
- Added support for grabbing the build number for a particular OS in
GTMSystemVersion and easily comparing it to known build numbers, and switched
some types from in GTMSystemVersion from "int" to SInt32 to make 64 bit work
better.
- Added support for SnowLeopard (10A96). We build cleanly with the 10.6 SDKs and
all radar checks were updated accordingly. Build All script was also updated
to build on SnowLeopard if you have the SDK available.
- Turned off building ppc64 GTM because the SnowLeopard SDK currently
doesn't have ppc64 support, so SenTestCase isn't defined. This makes it
impossible to build the ppc64 10.5 config on SnowLeopard. We have left the
setting in the xcconfig for those of you who need it, but have disabled
it in the GTM project settings.
- Turned on stack smashing protection on the debug builds for all Leopard
and above.
- Added ability to easily do leak checking by defining the GTM_ENABLE_LEAKS
environment variable. It isn't on by default because several of Apple's
frameworks leak. You can work around these false positives by using the
GTM_LEAKS_SYMBOLS_TO_IGNORE environment variable. Also if you turn on leaks
make sure to turn off zombies by defining the GTM_DISABLE_ZOMBIES variable,
otherwise every memory allocation you do will look like a leak.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added leaks checking to iPhone unit test script. It can be controlled by
the GTM_DISABLE_LEAKS environment variable
- Added ability to control using zombies to iPhone unit test script. It can be
controlled by the GTM_DISABLE_ZOMBIES environment variable
- Added ability to control termination to iPhone unit test script. It can be
controlled by the GTM_DISABLE_TERMINATION environment variable
- Fixed several leaks found with leak checking enabled.
- Added configs for different iPhone OS versions.
|
|
warning: variable 'r' might be clobbered by 'longjmp' or 'vfork'
when using certain Apple inlined functions in @synchronized/@try blocks.
- Updated to Xcode 3.1 so the GTM and iPhone project have the same baseline.
The code should work in other version of xcode, but the projects and
xcconfig files now use 3.1 features.
- Added GTMABAddressBook which is a cocoa wrapper for the 'C' AddressBook
APIs on the iPhone.
- Added several set environment variable statements to RunIPhoneUnitTest.sh
to encourage bugs to come out of the woodwork.
|