| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
| |
Remove unneeded import.
TBR=dmaclach
|
|
|
|
|
|
|
|
|
|
|
| |
Fix error-case memory leak in GTMSMJobRemove.
GTMPerformOnLabel will create an error in &local_error when it returns
NULL, so there is no need to create yet another error in local_error.
It masks the error created by GTMPerformOnLabel, which is leaked.
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=2 (0 added, 2 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Remove analyzer warning for returning released memory.
R=thomasvl
APPROVED=thomasvl
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up final GTM issues that I know of for format.
TBR=thomasvl
DELTA=16 (16 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Turn off warnings on gcc. Leave them on on clang.
R=thomasvl
DELTA=32 (30 added, 2 deleted, 0 changed)
|
|
|
|
|
|
|
| |
removing inconsistent and confusing URLWithString method
R=dmaclach
APPROVED=dmaclach
DELTA=26 (0 added, 21 deleted, 5 changed)
|
|
|
|
|
|
| |
Some more google toolbox cleanup.
TBR=thomasvl
DELTA=25 (6 added, 2 deleted, 17 changed)
|
|
|
|
|
|
| |
Clean up all of our format string issues amongst some other fun stuff.
R=thomasvl
DELTA=167 (90 added, 8 deleted, 69 changed)
|
|
|
|
|
|
| |
Add header back in attempt to fix build.
TBR=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Clean up some basic issues in GTM.
Also removes GTMUniqueFileObjectPathBasedOn which depended on mktemp which is
bad.
R=thomasvl
DELTA=55 (6 added, 32 deleted, 17 changed)
|
|
|
|
|
| |
Fix place attributes aren't passed for older Mac OS versions.
TBR=dmaclach
|
|
|
|
|
| |
Missing semi for old Mac OS SDKs.
TBR=dmaclach
|
|
|
|
|
|
| |
Small fixes for iOS.
R=dmaclach
DELTA=8 (0 added, 2 deleted, 6 changed)
|
|
|
|
|
| |
Fix wrong CPP gate.
TBR=dmaclach
|
|
|
|
|
|
| |
Pile of fixes for trunk version of clang.
R=dmaclach
DELTA=59 (26 added, 0 deleted, 33 changed)
|
|
|
|
|
|
|
| |
Expose internal GTMLogger logging method for subclasses to override.
R=thomasvl
APPROVED=thomasvl
DELTA=20 (9 added, 10 deleted, 1 changed)
|
|
|
|
|
|
| |
Implement sel_isEqual
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
|
| |
SDK might allow blocks, but the code the test calls requires it (and 10.5
thread apis), so instead check the min versions before building the test.
R=dmaclach
DELTA=3 (0 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Fix build for older SDKs.
Rename parameter to avoid issue with extra compiler flags.
TBR=dmaclach
|
|
|
|
|
|
| |
Add a blocks API to NSThread.
R=thomasvl,grobbins
DELTA=238 (236 added, 1 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up gate to match the ones above for handling older OS versions.
R=dmaclach
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Skip sending -class to to self in class methods.
R=dmaclach
DELTA=3 (0 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Flexible builder for URLs.
R=altse,dmaclach,thomasvl
APPROVED=dmaclach
|
|
|
|
|
|
| |
Add better error handling.
R=thomasvl
DELTA=13 (0 added, 0 deleted, 13 changed)
|
|
|
|
|
|
|
| |
Fix typo on test name so it wasn't running.
Fix the loops to use compression level 9 also.
R=dmaclach
DELTA=4 (0 added, 0 deleted, 4 changed)
|
|
|
|
|
|
|
| |
Allow the GTMLogger macros to be remapped in a prefix by checking if they
are defined before defining them.
R=dmaclach
DELTA=5 (5 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Add support for raw inflate/deflate without a header.
R=dmaclach
DELTA=416 (327 added, 69 deleted, 20 changed)
|
|
|
|
|
|
|
| |
Add check for iOS and Xcode 4 behaviors that makes everything appears to
be a system path by old check.
R=dmaclach
DELTA=7 (5 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Make the test a little better at getting large data for future tweaks to
the buffer size.
R=dmaclach
|
|
|
|
|
|
|
| |
Document that for 64bit, >32bit length is not supported.
Remove TODOs as they don't make sense to do.
R=dmaclach
DELTA=16 (6 added, 0 deleted, 10 changed)
|
|
|
|
|
|
|
| |
Add test to make sure we exercise the codes paths that require more then
on loop to deflate/inflate.
R=dmaclach
DELTA=33 (33 added, 0 deleted, 0 changed)
|
|
|
|
|
| |
Get the right version number when running under the simulator.
R=dmaclach
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move a bunch of tests over onto the GTM test base class.
Fetch some test images from the bundle the test is compiled into instead
of assuming main app.
Change the default iOS logging directory to just be the documents directory
since it should work for all iOS versions.
Add initial support for using SenTestingKit instead of our custom version
to allow the Xcode 4 UI for unittesting.
Add a target for using SenTestingKit.
Add a shell app for the TEST_HOST for SenTestingKit usage (since there are
UI tests, we need to use a real app and not the octest binary).
R=dmaclach
DELTA=517 (482 added, 9 deleted, 26 changed)
|
|
|
|
|
|
|
|
|
| |
- Make custom level filters much more flexible (arbitrary level combinations).
- Remove older custom level class to prevent confusion.
- Add a new standard logger that tries to produce a reasonable stdout/stderr
split for commandline tools.
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
| |
Clean up clang issues in GTM. The one in GTMABAddressBook is a weird one, that I'll try and file a bug on.
R=thomasvl
DELTA=92 (53 added, 6 deleted, 33 changed)
|
|
|
|
|
|
| |
Catch everything, not just NSException.
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launchctl on Mac OS X 10.7 ("Lion") requires launchd plist pathnames
to end in ".plist".
Files that don't end in plist result in launchctl printing this
message and ignoring the file:
launchctl: Dubious file. Not of type .plist (skipping):
/tmp/GTMServiceManagement.W3Pz4K
http://crbug.com/93274
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=3 (1 added, 1 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix duplicated test
R=thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
| |
Add a log filter that filters by simple level comparisons.
R=dmaclach,thomasvl
APPROVED=dmaclach
|
|
|
|
|
|
| |
Fix up release decl so that clang doesn't complain.
R=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
|
| |
Logging doesn't get to call assert() or exit() even when its very sad. Logging
isn't in charge of killing the process. Internal exceptions need catching too.
Plus some minor cleanup along the way, and better handling of
GTMVerboseLogging in the environment.
R=dmaclach,thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
|
| |
Get rid of warning in debug mode (%d used for NSUInteger). Just use
%lu instead and cast to unsigned long (largest NSUInteger can be).
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix ASL logging to reference the correct formatter (and then replace with
a new formatter).
- Format ASL messages to include information that would normally be present
in the standard formatter.
- Allow ASL writers to pass a facility string.
- Pretty up the function names in all logging, better matching NSAssert()
names (as one example).
- Don't throw if a logging filehandle is closed (SIGPIPE). Random exceptions
from logging is bad, m'kay?
R=thomasvl,dmaclach
APPROVED=thomasvl
|
|
|
|
|
|
|
| |
Fix up case where we were picking up an invalid errno value when the child process
was exiting with a bad exit status.
TBR=thomasvl
DELTA=9 (3 added, 0 deleted, 6 changed)
|
|
|
|
|
|
| |
Fix up HORRIBLE bug closing bad file descriptors.
R=thomasvl
DELTA=5 (1 added, 0 deleted, 4 changed)
|
|
|
|
|
|
|
|
| |
Fix interaction of GTMFileSystemKqueue when the runloop isn't spinning. Also,
don't count on kCFSocketReadCallBack to keep calling us, empty the queue
whenever we can.
DELTA=93 (84 added, 0 deleted, 9 changed)
R=dmaclach,thomasvl
|
|
|
|
|
|
| |
Works around a compiler bug on x86_64.
R=thomasvl
DELTA=9 (1 added, 1 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Fix for building GTM on Snow Leopard.
We were getting errors for being unable to protect buffers smaller than 8 chars.
R=aharper,thomasvl
DELTA=7 (4 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
|
| |
Fixes up build problem on gcc 4.0 release with Xcode 3.2.5
where it doesn't deal with "interesting" ascii in @"" constants
very well.
DELTA=35 (29 added, 0 deleted, 6 changed)
R=thomasvl
|
|
|
|
|
|
|
| |
Add include for objc/message.h as objc/runtime on the iOS SDK doesn't include it
so objc_msgSend symbol is not explicitly included.
R=thomasvl
DELTA=1 (1 added, 0 deleted, 0 changed)
|