| Commit message (Collapse) | Author | Age |
|
|
| |
It has been obsolete since 10.5.
|
|
|
| |
Use NSJSONSerialization instead.
|
|
|
| |
The URLArgument categories should be replaced with usages of NSURLComponents and NSURLItems.
|
|
|
| |
These were functions that dealt with Aliases.
|
|
|
| |
This check is very flaky from OS version to OS version and whether or not you are running under the debugger.
|
|
|
|
|
|
|
| |
This gets GTMSignalHandler working with libdispatch, and also marks it
as deprecated because it is probably easier just to write your own
version to call a block instead of the method invocation here.
This also makes the tests run again which hasn't been happening for
a long time AFAICT.
|
|
|
|
|
| |
There was a race between the thread being finished and
isFinished/isExecuting reporting correctly.
There may have also been a locking issue on older single processor phones.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit 585330a68d00c4d76927ff7bf4829471944358ab.
|
|
|
|
|
|
|
| |
Basically a complete rewrite of GTMSimpleWorkerThread that should get rid of a race condition
when stopping tests and testing for "isExecuting/isFinished".
It does change the observed behaviour of GTMSimpleWorkerThread a little in that "start" no longer
blocks until the thread is starting, and we removed the unused "stop" method.
|
|
|
|
|
| |
- Set up stack trace test just so we make sure we don't recurse. Right now it is too tight and breaks on every system release.
- SQLite's behavior is actually undefined in the case of sqlite3_errcode, so don't depend on it in a test.
|
|
|
|
|
|
|
| |
ubsan output:
.../google_toolbox_for_mac/Foundation/GTMStringEncoding.m:204:16: runtime error: left shift of 10368305 by 8 places cannot be represented in type 'int'
.../google_toolbox_for_mac/Foundation/GTMStringEncoding.m:312:16: runtime error: left shift of 42406098 by 6 places cannot be represented in type 'int'
TESTED=Earth iOS --featires=ubsan
|
| |
|
|
|
|
|
|
|
| |
- Keep Gestalt APIs till 10.8.
- On 10.8 and 10.9 use sysctl and infer the OS version from there.
- On 10.10+ use NSProcessInfo.
- Added unit test to cover it.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In https://crbug.com/747643, a new version of Clang produces warnings
when attempting to format NSInteger as %zd (which is normally used for
ssize_t). Acquiesce by casting NSInteger to long and formatting using
%ld.
In the process, I audited all occurrences of %zd in GTM and found that
the remainder were being used to format size_t, which ought to use %zu,
so I’ve corrected those.
I also audited the existing uses of %zu and found them all to be
correct.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting in the 10.6 SDK, the non-underscored and all-lowercase macro
names in <AssertMacros.h> were deprecated. In the 10.13 SDK shipping in
Xcode 9 beta 3 (but not previous betas of Xcode 9), Apple has made good
on its promise to eventually disable these names. Update GTM to use the
new underscored mixed-case names.
Provided that nobody needs to target anything older than the 10.5 SDK
anymore, this should be a safe change.
Aside from GTMCarbonEvent.m, which is used by Chrome, this change is
untested, and was made by mechanically replacing uses of the various
check, require, and verify macros found in GTM.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of code that Google stopped using/maintaining rather than trying
to update it it. Some would be hard to update, some actually has system provided
replacements; others are patterns that just don't seem as common now.
Prune out the code related to macOS <= 10.5, start pruning some of the really
old iOS support also.
Get the projects mostly limping again with modern Xcodes so tests can be run.
If someone ends up on this commit via history for something they still find
as useful, feel free to do a pull request to bring the snippet of code back to
life and update it for current SDKs.
|
|
|
|
|
|
|
|
|
| |
This avoids checking if verbose logging is enabled on every user defaults
change, and only does so when the verbose logging key changes.
In sampling a few apps, this showed up as a hit when the app changes default
(directly or via the System frameworks storing things). By using KVO for it
it basically disappears from the samples.
|
|
|
|
|
|
| |
Gestalt() is deprecated with a 10.8 deployment target. Use the
recommended replacement when deploying to 10.8 and 10.9, and just
use a constant function when deploying to 10.10.
|
|
|
|
|
|
| |
They have become too invasive and cause more issues than they were solving,
especially on iOS where they seem to interact very badly with the accessibility
provided by the OS.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Remove GTMCGPointToNSPoint, GTMNSPointToCGPoint, GTMCGRectToNSRect, GTMCGSizeToNSSize
Note that Apple's NSGeometry.h sometimes defines
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
so there's some reason to believe the CG and NS structs can compile incompatibly.
Fix a typo in GTMSenTestCase.h
|
| |
|
| |
|
|
|
|
| |
in static libs to avoid linker warnings
|
|
|
|
| |
static libs to avoid linker warnings
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
previous OSX versions.
In OSX 10.10+, launch_msg(LAUNCH_KEY_REMOVEJOB, ...) returns the error
EINPROGRESS if the job was running at the time it was removed. In OSX 10.9 and
earlier, the same function call returns success. This CL makes GTMSMJobRemove()
treat the error EINPROGRESS as success on OSX 10.10+.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
period into account for the total suffix-length to pass to mkstemps.
Example failure:
template = myTempXXX.ext
pathExtension = "ext"
[pathExtension length] = 3
Need for mkstemps:
suffix-length = 4 (".ext")
DELTA=6 (5 added, 0 deleted, 1 changed)
DELTA_BY_EXTENSION=m=6
|
|
|
|
|
|
| |
Change stringWithContentsOfFile to explicitly specify the encoding (again, 10.4 fix)
DELTA=85 (4 added, 2 deleted, 79 changed)
DELTA_BY_EXTENSION=c=3,m=80
|
|
|
|
|
|
|
|
|
| |
a) only define GTM_IPHONE_USE_SENTEST if it hasn't been defined on Mac. It's a horrible name, but
it does control us using SENTEST instead of XCTest.
b) Object is now found in the runtime on both iOS and MacOS
c) MethodCheck had a potential memory leak
DELTA=47 (18 added, 5 deleted, 24 changed)
DELTA_BY_EXTENSION=h=30,m=12
|
|
|
|
|
|
| |
CFAutorelease. Update GTM's definition of the standard OS X/iOS version macros. Remove GTMDefines dependency from GTMNSString+URLArguments and GTMURITemplate.
DELTA=38 (27 added, 4 deleted, 7 changed)
DELTA_BY_EXTENSION=h=23,m=11
|
|
|
| |
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
| |
DELTA=23 (16 added, 0 deleted, 7 changed)
|
|
|
| |
DELTA=32 (32 added, 0 deleted, 0 changed)
|