aboutsummaryrefslogtreecommitdiff
path: root/AppKit
Commit message (Collapse)AuthorAge
* Remove GTMWindowSheetController (#256)Gravatar dmaclach2020-03-05
| | | | | | | Hasn't really been maintained, Chromium was one of the main users, and they stopped using it a while ago, they only use a few things now: https://chromium.googlesource.com/chromium/src/+/master/third_party/google_toolbox_for_mac/BUILD.gn It also never was in the pod file, meaning less folks were likely to use it.
* GTMLocalizer: use NSAccessibility on 10.10+ deployment targetsGravatar Elly Fong-Jones2019-02-19
| | | | | | | | | | | This change makes GTMLocalizer use NSAccessibility when building for 10.10+ deployment targets. I tested this change by: 1) Hacking the GTM Xcode project to build with a 10.10 deployment target, and ignoring the other deprecated API uses; 2) Patching this GTM into the chromium tree (which does target 10.10) and ensuring that it still builds
* Project modernization.Gravatar Thomas Van Lenten2018-11-15
| | | | | | | | | - Create shared scheme to use. - Let Xcode (9.4.1) update the project files and add some warnings. - Remove -finalize (GC days are gone) - Add some more pragmas to compile cleanly. - The iOS targets had a mix of 7.0 and 8.0 min versions, so make them all 8.
* Set GTM deployment target to macOS 10.7. (#208)Gravatar dmaclach2018-11-14
| | | Tests and code all build and run with no warnings.
* Remove GTMLoginItems (#196)Gravatar dmaclach2018-11-13
| | | | This functionality is no longer supported on OS X. Use a LaunchAgent, XPCService or the ServiceManagement APIs instead.
* Remove old uses of GTM_FOREACH_KEY (#194)Gravatar dmaclach2018-11-13
|
* Move GTMCarbonEvent over to XCTestExpectation (#188)Gravatar dmaclach2018-11-12
|
* Move animation over to XCTestExpectation (#187)Gravatar dmaclach2018-11-12
|
* 10.13 SDK (and iOS 11 equivalent) compatibility for GTMGravatar Mark Mentovai2017-07-10
| | | | | | | | | | | | | | | Starting in the 10.6 SDK, the non-underscored and all-lowercase macro names in <AssertMacros.h> were deprecated. In the 10.13 SDK shipping in Xcode 9 beta 3 (but not previous betas of Xcode 9), Apple has made good on its promise to eventually disable these names. Update GTM to use the new underscored mixed-case names. Provided that nobody needs to target anything older than the 10.5 SDK anymore, this should be a safe change. Aside from GTMCarbonEvent.m, which is used by Chrome, this change is untested, and was made by mechanically replacing uses of the various check, require, and verify macros found in GTM.
* Remove trailing whitespacesGravatar Sergio Campama2017-03-29
|
* First cut at pruning things/updating things.Gravatar dmaclach2016-10-07
| | | | | | | | | | | | | | | Remove a bunch of code that Google stopped using/maintaining rather than trying to update it it. Some would be hard to update, some actually has system provided replacements; others are patterns that just don't seem as common now. Prune out the code related to macOS <= 10.5, start pruning some of the really old iOS support also. Get the projects mostly limping again with modern Xcodes so tests can be run. If someone ends up on this commit via history for something they still find as useful, feel free to do a pull request to bring the snippet of code back to life and update it for current SDKs.
* Update GTMDebugThreadValidation with general queue support.Gravatar Thomas Van Lenten2016-04-29
|
* Fix GTMGeometry builds on 64 bit OS X where CG and NS struct sizes may differ.Gravatar Thomas Van Lenten2016-04-07
| | | | | | | | | | Remove GTMCGPointToNSPoint, GTMNSPointToCGPoint, GTMCGRectToNSRect, GTMCGSizeToNSSize Note that Apple's NSGeometry.h sometimes defines NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES so there's some reason to believe the CG and NS structs can compile incompatibly. Fix a typo in GTMSenTestCase.h
* Keep GTM building after clang r251041 when targeting 10.6Gravatar Thomas Van Lenten2015-11-03
|
* add pragmas to suppress deprecated warnings from newer SDKsGravatar Thomas Van Lenten2015-09-08
|
* Fix build of Mac GTM project with static analyzer. Remove ↵Gravatar gtm.daemon2013-12-19
| | | | | GTMGarbageCollection. Remove GC build configs. Remove internal dependence on GTMObjectSingleton. DELTA=447 (49 added, 296 deleted, 102 changed)
* Ensure +[GTMUILocalizerAndLayoutTweaker sizeToFitFixedHeightTextField:] ↵Gravatar gtm.daemon2013-06-24
| | | | | | | sets an integral size. When resizing labels it's possible to get fractional sizes. This CL fixes the problem by using integral values. DELTA=17 (17 added, 0 deleted, 0 changed)
* Make GTMUILocalizer's IBOutlet fields @protected. ↵Gravatar gtm.daemon2013-04-03
| | | | | | | | | Private fields are turned into hidden symbols with the 64bit runtime, so classes that are not in the same dylib / framework as GTMUILocalizer cannot access these fields otherwise. This is for http://crbug.com/190508 DELTA=2 (1 added, 0 deleted, 1 changed)
* No need for [self class] in a class method.Gravatar gtm.daemon2013-02-13
| | | DELTA=26 (0 added, 0 deleted, 26 changed)
* [Author: thomasvl]Gravatar gtm.daemon2013-01-02
| | | | | | | | Remove the GC support code. Add the needed images for the iOS unittests under iOS 6.0. Add a workspace file for the iPhone project. R=dmaclach DELTA=215 (85 added, 122 deleted, 8 changed)
* [Author: thomasvl]Gravatar gtm.daemon2012-09-17
| | | | | | | Properly support top level parent view. http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=86 R=sail DELTA=2 (0 added, 1 deleted, 1 changed)
* [Author: dmaclach]Gravatar gtm.daemon2012-07-24
| | | | | | Clean up all of our format string issues amongst some other fun stuff. R=thomasvl DELTA=167 (90 added, 8 deleted, 69 changed)
* [Author: dmaclach]Gravatar gtm.daemon2012-06-21
| | | | | | | | | Clean up some basic issues in GTM. Also removes GTMUniqueFileObjectPathBasedOn which depended on mktemp which is bad. R=thomasvl DELTA=55 (6 added, 32 deleted, 17 changed)
* [Author: thomasvl]Gravatar gtm.daemon2012-03-07
| | | | | | Skip sending -class to to self in class methods. R=dmaclach DELTA=3 (0 added, 0 deleted, 3 changed)
* [Author: dmaclach]Gravatar gtm.daemon2012-02-27
| | | | | | | Fix up -wformat warnings that clang was reporting crbug.com/115847 TBR=thomasvl DELTA=2 (0 added, 0 deleted, 2 changed)
* [Author: thomasvl]Gravatar gtm.daemon2012-02-06
| | | | | | | | | Always uses the first element of the array for the sizeof calc rather then hard coding the type. Fixes an error with newer compiler where we did sizeof(NSColor) instead of sizeof(NSColor*). Fix warning about assignment of variable to itself. R=dmaclach DELTA=5 (0 added, 0 deleted, 5 changed)
* [Author: thomasvl]Gravatar gtm.daemon2011-11-11
| | | | | Finish fixing up the tests on 10.6.7. TBR=dmaclach
* [Author: thomasvl]Gravatar gtm.daemon2011-11-10
| | | | | Yes, 10.6.7 with the 10.4 SDK draws some things differently. TBR=dmaclach
* [Author: thomasvl]Gravatar gtm.daemon2011-11-03
| | | | | | | | | | | | | | | Fix memory model by making all the outlets assign not retain. The problem here is UIViewControllers will dump their view in low memory and then reload next time it is needed. So someone hangs on to the localizer for something else, it would keep the views also loaded, so this way the localizer won't keep any of the objects it points to alive via a retain. Note: the AppKit version sorta matches this since outlets aren't retained by default. Clear them in awakeFromNib since that is all they are needed for. R=dmaclach DELTA=19 (9 added, 0 deleted, 10 changed)
* [Author: thomasvl]Gravatar gtm.daemon2011-11-02
| | | | | | | | | | | | | | - Support for localizing non datasource versions of NSComboxBox (http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=77). - Fix up some category names. - Avoid conflicting category names. - Move placeholder string support down to NSTextField instead of NSSearchField. - Support for NSTextField placeholder in unittesting state. - Support for non datasource combobox values in unittesting state. - Fix NSSegmentControl localization support. - Add explicit tests for no localized values and document it in the strings file. - Unittesting for as much as possible of the above. R=dmaclach DELTA=762 (660 added, 55 deleted, 47 changed)
* [Author: thomasvl]Gravatar gtm.daemon2011-11-01
| | | | | | Add reference image for 10.6.8 since it seems the sizing of bezel buttons changed. TBR=dmaclach
* [Author: rsesek]Gravatar gtm.daemon2011-08-09
| | | | | | In GTM SizeToFit(), add more padding for NSTexturedRoundedBezelStyle buttons. R=thomasvl APPROVED=thomasvl
* [Author: avi]Gravatar gtm.daemon2011-08-08
| | | | | | Switch to using the class methods +saveGraphicsState/+restoreGraphicsState. R=mmentovai APPROVED=dmaclach
* [Author: thomasvl]Gravatar gtm.daemon2011-07-20
| | | | | | Fix typo. R=dmaclach DELTA=1 (0 added, 0 deleted, 1 changed)
* [Author: dmaclach]Gravatar gtm.daemon2011-07-20
| | | | | | Fix up missing space. R=thomasvl DELTA=1 (0 added, 0 deleted, 1 changed)
* [Author: dmaclach]Gravatar gtm.daemon2011-07-20
| | | | | | Fix up test that didn't compile on SnowLeopard due to protocols. TBR=thomasvl DELTA=1 (0 added, 0 deleted, 1 changed)
* [Author: dmaclach]Gravatar gtm.daemon2011-07-20
| | | | | | | | | Adds a simple key value animation class. CAAnimation doesn't really allow you to animate things that aren't part of CALayers, and this gets us 90% of the way there to being able to not have to subclass NSAnimation for every animation we want to do. R=mikemorton DELTA=155 (155 added, 0 deleted, 0 changed)
* Added by hand due to perforce problems. GTMKeyValueAnimation is a simple key ↵Gravatar dmaclach2011-07-14
| | | | path animation class based on NSAnimation
* [Author: thakis]Gravatar gtm.daemon2011-04-14
| | | | | | | | | | Make implicit assumptions in GTMWindowSheetController explicit by adding asserts. Original review at http://codereview.appspot.com/4418041/ R=avi APPROVED=avi DELTA=8 (6 added, 0 deleted, 2 changed)
* [Author: sail]Gravatar gtm.daemon2011-03-28
| | | | | | | | | | | Tweak fade effect for GTMFadeTruncatingTextFieldCell This change tweaks how we fade the beginning of the text in GTMFadeTruncatingTextFieldCell. Previously we would start drawing the string at the desired position. This meant that the first character was not legible because of the fade effect. With this change we now start drawing a few pixels before the desired position. I also fixed a bug in how we draw the background of the cell. Previously we clipped to the text rect before drawing the background. When the text field had a border this meant that we weren't drawing all of the background because the text rect is slightly smaller than the background rect. With this change we now draw the background rect before setting the text rect clip. R=thomasvl,dmaclach APPROVED=dmaclach DELTA=81 (51 added, 2 deleted, 28 changed)
* [Author: sail]Gravatar gtm.daemon2011-03-18
| | | | | | | | | | | Currently GTMFadeTruncatingTextFieldCell only supports truncating the tail of a string. It should also allow the head of a string to be truncated. I'd like to use this in Chromium. See http://crbug.com/69304 R=thomasvl APPROVED=thomasvl DELTA=238 (197 added, 17 deleted, 24 changed)
* [Author: dmaclach]Gravatar gtm.daemon2011-02-03
| | | | | | | Fix for building GTM on Snow Leopard. We were getting errors for being unable to protect buffers smaller than 8 chars. R=aharper,thomasvl DELTA=7 (4 added, 0 deleted, 3 changed)
* [Author: avi]Gravatar gtm.daemon2011-01-20
| | | | | | Pull __weak modifier from variable whose value is actually owned. R=thakis DELTA=1 (0 added, 0 deleted, 1 changed)
* [Author: thakis]Gravatar gtm.daemon2011-01-07
| | | | | | | | | Fix a harmless clang warning about the self-assignment duration = duration; R=thomasvl APPROVED=thomasvl DELTA=6 (0 added, 1 deleted, 5 changed)
* [Author: dmaclach]Gravatar gtm.daemon2010-11-10
| | | | | | | Fix up GTMHotKeyTextField so that it compiles cleanly with format string warnings on. Change to match other controls where string value always returns the empty string as opposed to nil. R=thomasvl DELTA=7 (4 added, 0 deleted, 3 changed)
* [Author: avi]Gravatar gtm.daemon2010-11-08
| | | | | | Allow adding a new sheet in a sheet's closing callback in GTMWindowSheetController. GTMWindowSheetController does not completely remove a sheet until after the callback has been invoked. This causes an assert to trigger if another sheet is launched in the callback, which is inconsistent with normal Cocoa sheets. Switch the order of the two operations and add a unit test. This affects http://crbug.com/56948 . Patch by davidben@chromium.org . R=dmaclach DELTA=112 (106 added, 5 deleted, 1 changed)
* [Author: dmaclach]Gravatar gtm.daemon2010-10-06
| | | | | | Set resizing defaults for GTMLargeTypeWindow to something sane. R=thomasvl DELTA=2 (2 added, 0 deleted, 0 changed)
* [Author: dmaclach]Gravatar gtm.daemon2010-09-30
| | | | | | | Fix up GTMCarbonEvent to fix a major bug with comparing events. Also increases error checking and makes debugging easier. R=thomasvl DELTA=18 (6 added, 0 deleted, 12 changed)
* [Author: dmaclach]Gravatar gtm.daemon2010-09-30
| | | | | | Allow tabbing to move around dialog, and add a description method. R=thomasvl DELTA=11 (10 added, 0 deleted, 1 changed)
* [Author: aharper]Gravatar gtm.daemon2010-09-29
| | | | | | | GTMHotKeyTextField on 10.4 again, properties are too new, so write custom accessors. DELTA=47 (29 added, 18 deleted, 0 changed) R=dmaclach