| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Fix up build machine issue.
TBR=thomasvl
DELTA=6 (3 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Turns on the undeclared-selector warning. This may cause builds to fail if they are using
our configs. Also cleaned up some whitespace issues.
R=thomasvl
DELTA=94 (71 added, 22 deleted, 1 changed)
|
|
|
|
|
|
| |
Another Leopard PCH casualty..
DELTA=0 (0 added, 0 deleted, 0 changed)
R=thomasvl
|
|
|
|
|
|
| |
Fix up build on Leopard.
R=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Cleans up builds of GTM on Snow Leopard with gcc 4.2.
Cleans up iPhone configs
Adds libgcov for Snow Leopard
Fixes up some small bugs.
R=thomasvl
DELTA=2028 (972 added, 990 deleted, 66 changed)
|
|
|
|
|
|
| |
Add missing files from previous checkin.
R=thomasvl
DELTA=0 (0 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
There are still a couple of errors occurring, but this fixes up the majority of stuff. I figured I'd send it out to you now to take
a look at in the morning, and then we can clean up the last couple of issues.
Not quite sure what to do about the naming of data files so that we can encompass ranges of system version (e.g. this file applies to
10.5 and 10.6 but not 10.4 or 10.7.
R=thomasvl
DELTA=10598 (10211 added, 70 deleted, 317 changed)
|
|
|
|
|
|
| |
Typo fix in selector name.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
| |
refactor GTMUnitTestingUtilities into GTMAppKitUnitTestingUtilties and GTMFoundationUnitTestingUtilities.
convert GTMSignalHandler over to using new runloop routines
fix bug in GTMSignalHandler API with GC where releasing it wasn't sufficient to stop it listening.
R=thomasvl
DELTA=1227 (638 added, 566 deleted, 23 changed)
|
|
|
|
|
|
| |
Add utility code to make it faster, easier and more robust to spin runloops during tests.
R=thomasvl
DELTA=186 (140 added, 19 deleted, 27 changed)
|
|
|
|
|
|
| |
Want mouse up not down for the animation slowdowns.
R=dmaclach
DELTA=7 (0 added, 0 deleted, 7 changed)
|
|
|
|
|
|
|
|
|
| |
NSEvent throws if you call -characters on a non key event, so instead of
checking the requested mask, we have to check the event type (say someone
uses any event as the mask, and it's a click event...)
Also handle keydown or up for the tab check.
R=dmaclach,stuartmorgan
DELTA=8 (1 added, 0 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Add a radar number for the sizeToFit padding issue.
Reorder two functions in the impl to match the header.
R=dmaclach
DELTA=55 (28 added, 27 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
| |
Put the padding tweak in to the NSMatrix path also for wrapped strings
since they can have the same problems as standalong radio/checkboxes.
The padding amount also is increased slightly to handle Kerning that can
happen on some european languages (accent chars).
Move some constants into global constants in the file for general cleanup.
R=dmaclach,stuartmorgan
DELTA=36 (26 added, 8 deleted, 2 changed)
|
|
|
|
|
|
| |
Fix up shadowed var problem.
R=thomasvl
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
|
|
| |
use LaunchServices APIs when running on 10.5 and above.
R=dmaclach,thomasvl
APPROVED=dmaclach
DELTA=150 (150 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Clean up issues brought up in recent TBR.
Check for single character, and check to make sure ctrl isn't down as well.
R=thomasvl
DELTA=2 (1 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
|
| |
Stop animation slow down applying to shift-tabs.
Tab and shift-tab are often used for navigating around UI elements,
and in the majority of cases slowing down the animations while
navigating around UI elements is not desired.
TBR=thomasvl,mrossetti
DELTA=24 (15 added, 4 deleted, 5 changed)
|
|
|
|
|
|
| |
Add a fudge factor for buttons (radios, checkboxes) that have forced wordwraps.
R=dmaclach
DELTA=11 (11 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
| |
This may help clean up some code in chrome, and make doing animations on
the mac easier in general. Not really sure how to unit test effectively, but
I'll try and come up with something this evening. Hopefully you will get a
chance to look at it, so Andy can use it for his current CL in flight
http://codereview.chromium.org/1118004.
R=thomasvl
DELTA=908 (908 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
If a width base tweaker is adjusting a window's size with the result, apply
the calculations needed for Resolution Independence also.
R=avi,dmaclach
DELTA=5 (3 added, 0 deleted, 2 changed)
|
|
|
|
|
|
|
| |
Use the transforms needed to deal with Resolution Independence when sizing
the window.
R=avi,dmaclach
DELTA=4 (3 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Reinstate the carbon event application handler.
R=thomasvl
DELTA=48 (48 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Remove commented out line I missed in last CL.
R=dmaclach
DELTA=1 (0 added, 1 deleted, 0 changed)
|
|
|
|
|
|
| |
Change over animation so it will work with other event types than just mouse downs.
R=thomasvl
DELTA=33 (16 added, 1 deleted, 16 changed)
|
|
|
|
|
|
|
|
| |
Don't trim the whitespace off the string when doing test sizing...
TextField does some odd stuff with whitespace when it does wrap things, if you don't include the white space, then when you use the real string (to wrap), it moves the last word down a line because of lack of space for the whitespace (go figure).
Oh, and fix the leak.
R=dmaclach
DELTA=6 (0 added, 1 deleted, 5 changed)
|
|
|
|
|
|
| |
Make the size change math right.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Add an api for forcing a NSTextField to a fixed height but what ever width is needed.
R=dmaclach
DELTA=634 (631 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Kill off GTMTheme, never went as far as we wanted it too.
R=dmaclach
DELTA=750 (3 added, 747 deleted, 0 changed)
|
|
|
|
|
|
| |
Clean up a pile of API upgrade warnings from clang, and the dead store.
R=thomasvl
DELTA=13 (0 added, 3 deleted, 10 changed)
|
|
|
|
|
|
| |
Get rid of some warnings from clang.
R=thomasvl
DELTA=5 (0 added, 2 deleted, 3 changed)
|
|
|
|
|
|
| |
Add basic support for NSTabView and a unittest to validate simple behaviors.
R=dmaclach
DELTA=1069 (1066 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Removed unit test that was causing a leak that we would never see in run time
code.
R=thomasvl
DELTA=14 (0 added, 14 deleted, 0 changed)
|
|
|
|
|
|
| |
Clean up leaks in array test.
R=thomasvl
DELTA=10 (10 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Clean up GTMUILocalizer so that it has a single entry point. Bindings weren't
always being updated recursively.
R=thomasvl
DELTA=95 (45 added, 38 deleted, 12 changed)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=40.
Sets up GTMUILocalizer to localize some bindings. Handles:
NSMultipleValuesPlaceholderBindingOption
NSNoSelectionPlaceholderBindingOption
NSNotApplicablePlaceholderBindingOption
NSNullPlaceholderBindingOption
NSDisplayNameBindingOption,
NSDisplayPatternBindingOption,
R=thomasvl
DELTA=1475 (815 added, 596 deleted, 64 changed)
|
|
|
|
|
|
| |
Don't use key value coding to access private variables directly. Style issue.
R=thomasvl
DELTA=14 (11 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Added some basic casting debugging goodness to GTM.
Opinions? added to help catch a bug in QSB.
R=thomasvl
DELTA=55 (55 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Since we can't localize the AXDescription on elements, we shouldn't even try.
R=dmaclach,thomasvl
DELTA=55 (28 added, 20 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Make launchedApplications thread safe. Previous incarnation could easily
deadlock.
R=mrossetti,thomasvl
DELTA=53 (22 added, 0 deleted, 31 changed)
|
|
|
|
|
|
|
|
|
| |
Nicer drawing of text by not using the gradient where it isn't needed,
helps where light text is drawn on a dark background.
Patch from thakis - http://codereview.appspot.com/159060/show
R=thakis,dmaclach
DELTA=79 (54 added, 7 deleted, 18 changed)
|
|
|
|
|
|
|
| |
I appear to have added this directly to the external version by accident, hopefully the sync up script will be ok with this change.
R=dmaclach
TBR=dmaclach
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Put some better restrictions on the Animations so they don't happen
by accident. Imitates the minimize window behaviour.
R=thomasvl
DELTA=15 (8 added, 0 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Turns out I needed to expose a bit more API to make it work with all of the
animations in Chrome nicely.
R=thomasvl
DELTA=42 (30 added, 8 deleted, 4 changed)
|
|
|
|
|
|
|
| |
Forgot NSAnimationContext when adding duration support.
R=thomasvl
DELTA=13 (13 added, 0 deleted, 0 changed)
TBR=thomasvl
|
|
|
|
|
|
| |
Add animation duration controls to GTM.
R=thomasvl
DELTA=106 (106 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up GTMTheme so that it returns a color for iconColorForStyle:state:
and so that it doesn't broadcast notifications whenever the background
color is changed.
We need this class cleaned up. It's a real mess.
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=37
R=thomasvl
DELTA=12 (6 added, 3 deleted, 3 changed)
|
|
|
|
|
|
| |
Path control is 10.5 or later, add ifdef.
R=dmaclach,stuartmorgan
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Handle path controls in autosizing.
R=stuartmorgan
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Fix up GTMIBArray to work with 10.6 nib loading. Nib loading on 10.6
pushes all objects into hash maps, which caused the IBArray to latch
on to its empty state, so this provides overrides so they maintain
the contacts around hash and isEqual, but can't be loaded from a nib.
R=dmaclach,stuartmorgan
DELTA=68 (68 added, 0 deleted, 0 changed)
|