| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Kill off GTMTheme, never went as far as we wanted it too.
R=dmaclach
DELTA=750 (3 added, 747 deleted, 0 changed)
|
|
|
|
|
|
| |
Clean up a pile of API upgrade warnings from clang, and the dead store.
R=thomasvl
DELTA=13 (0 added, 3 deleted, 10 changed)
|
|
|
|
|
|
| |
Get rid of some warnings from clang.
R=thomasvl
DELTA=5 (0 added, 2 deleted, 3 changed)
|
|
|
|
|
|
| |
Add basic support for NSTabView and a unittest to validate simple behaviors.
R=dmaclach
DELTA=1069 (1066 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Removed unit test that was causing a leak that we would never see in run time
code.
R=thomasvl
DELTA=14 (0 added, 14 deleted, 0 changed)
|
|
|
|
|
|
| |
Clean up leaks in array test.
R=thomasvl
DELTA=10 (10 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Clean up GTMUILocalizer so that it has a single entry point. Bindings weren't
always being updated recursively.
R=thomasvl
DELTA=95 (45 added, 38 deleted, 12 changed)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=40.
Sets up GTMUILocalizer to localize some bindings. Handles:
NSMultipleValuesPlaceholderBindingOption
NSNoSelectionPlaceholderBindingOption
NSNotApplicablePlaceholderBindingOption
NSNullPlaceholderBindingOption
NSDisplayNameBindingOption,
NSDisplayPatternBindingOption,
R=thomasvl
DELTA=1475 (815 added, 596 deleted, 64 changed)
|
|
|
|
|
|
| |
Don't use key value coding to access private variables directly. Style issue.
R=thomasvl
DELTA=14 (11 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Added some basic casting debugging goodness to GTM.
Opinions? added to help catch a bug in QSB.
R=thomasvl
DELTA=55 (55 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Since we can't localize the AXDescription on elements, we shouldn't even try.
R=dmaclach,thomasvl
DELTA=55 (28 added, 20 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Make launchedApplications thread safe. Previous incarnation could easily
deadlock.
R=mrossetti,thomasvl
DELTA=53 (22 added, 0 deleted, 31 changed)
|
|
|
|
|
|
|
|
|
| |
Nicer drawing of text by not using the gradient where it isn't needed,
helps where light text is drawn on a dark background.
Patch from thakis - http://codereview.appspot.com/159060/show
R=thakis,dmaclach
DELTA=79 (54 added, 7 deleted, 18 changed)
|
|
|
|
|
|
|
| |
I appear to have added this directly to the external version by accident, hopefully the sync up script will be ok with this change.
R=dmaclach
TBR=dmaclach
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Put some better restrictions on the Animations so they don't happen
by accident. Imitates the minimize window behaviour.
R=thomasvl
DELTA=15 (8 added, 0 deleted, 7 changed)
|
|
|
|
|
|
|
| |
Turns out I needed to expose a bit more API to make it work with all of the
animations in Chrome nicely.
R=thomasvl
DELTA=42 (30 added, 8 deleted, 4 changed)
|
|
|
|
|
|
|
| |
Forgot NSAnimationContext when adding duration support.
R=thomasvl
DELTA=13 (13 added, 0 deleted, 0 changed)
TBR=thomasvl
|
|
|
|
|
|
| |
Add animation duration controls to GTM.
R=thomasvl
DELTA=106 (106 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up GTMTheme so that it returns a color for iconColorForStyle:state:
and so that it doesn't broadcast notifications whenever the background
color is changed.
We need this class cleaned up. It's a real mess.
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=37
R=thomasvl
DELTA=12 (6 added, 3 deleted, 3 changed)
|
|
|
|
|
|
| |
Path control is 10.5 or later, add ifdef.
R=dmaclach,stuartmorgan
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Handle path controls in autosizing.
R=stuartmorgan
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Fix up GTMIBArray to work with 10.6 nib loading. Nib loading on 10.6
pushes all objects into hash maps, which caused the IBArray to latch
on to its empty state, so this provides overrides so they maintain
the contacts around hash and isEqual, but can't be loaded from a nib.
R=dmaclach,stuartmorgan
DELTA=68 (68 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
| |
Add a helper for doing view resizing without resizing subviews.
Fix the fixed width call to not change the width.
Update the unittest to make sure the fixed width call doesn't change the width.
R=stuartmorgan,dmaclach
DELTA=41 (30 added, 0 deleted, 11 changed)
|
|
|
|
|
|
|
|
|
|
| |
Fix some garbage collecion related leaks.
Discovered in a run of the Clang Static Analyzer:
http://clang-analyzer.llvm.org/
R=dmaclach
APPROVED=dmaclach
DELTA=17 (11 added, 0 deleted, 6 changed)
|
|
|
|
|
|
|
|
| |
Adding GTMIBArray, a class that can be used in IB to build up an NSArray
directly, so developers don't need to add lots of outlets to other
objects and assemble things during awakeFromNib.
R=dmaclach
DELTA=1337 (1333 added, 0 deleted, 4 changed)
|
|
|
|
|
|
|
| |
Add two apis for making checkboxs/radios and radio groups wrap to their size.
Add a unittest to cover normal and mini sizes.
R=dmaclach,stuartmorgan
DELTA=1174 (1164 added, 0 deleted, 10 changed)
|
|
|
|
|
|
| |
Add pattern phase the way I really want it (for now).
R=thomasvl,alcor
DELTA=91 (31 added, 52 deleted, 8 changed)
|
|
|
|
|
|
|
| |
Fix up the unit tests that didn't actually run (I ran them on Tiger and GTMTheme is Leopard+ only).
Renamed backgroundImagePhase to backgroundPatternPhase which is a better name.
Added method for extracting a value directly from a theme.
R=thomasvl
|
|
|
|
|
|
| |
Add background phase to GTMTheme.
R=thomasvl
DELTA=49 (47 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Use class membership instead of string match.
R=mmentovai,avi
DELTA=6 (3 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
add a helper for resizing a window without the subview resizing.
R=stuartmorgan
DELTA=32 (32 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Thanks to thomasvl for catching my NSLog detritus.
R=thomasvl,mrossetti
DELTA=2 (0 added, 2 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up GTMNSWorkspace so that it's save to call gtm_launchedApplications on threads other than the main one.
R=mrossetti
DELTA=48 (26 added, 19 deleted, 3 changed)
|
|
|
|
|
|
| |
Fix up potential race condition returning launchedApps_.
R=thomasvl
DELTA=5 (2 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
|
|
|
| |
Support the toolbar item's view in state logging.
Add table columns to ui localizer (tests will come in a following cl).
Add a toolbar item that doesn't localize to help catch bugs in the future like we had on first impl.
Add a tooltip to the toolbar item in the unittest for ui localizer.
Add a note about the limits to ui localizer and toolbars due to the NSToolbar api's limits.
R=dmaclach
DELTA=746 (90 added, 599 deleted, 57 changed)
|
|
|
|
|
|
| |
Fix include
R=dmaclach,pinkerton
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up GTMUILocalizerTest which wasn't finding the nib with . in the name appropriately.
R=thomasvl,alcor
DELTA=5468 (2729 added, 2729 deleted, 10 changed)
|
|
|
|
|
|
| |
Get rid of ObjC 2ism for compiling on Tiger.
R=thomasvl,alcor
DELTA=2 (1 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Adds CGFloat support to NSNumber
R=thomasvl
DELTA=219 (217 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Fix up test so that it doesn't run on Tiger.
R=thomasvl,alcor
DELTA=3 (3 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up unit test for GTMFadeTruncatingTextFieldCellTest so that it only runs on Leopard+.
R=thomasvl,alcor
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix toolbar localizer test
R=thomasvl
DELTA=2780 (2767 added, 6 deleted, 7 changed)
|
|
|
|
|
|
|
|
| |
Update Large UI with latest nib
Add toolbar to prefs
Add toolbar localization
R=dmaclach
DELTA=4125 (3054 added, 462 deleted, 609 changed)
|
|
|
|
|
|
| |
Add the NSImage Search category
R=dmaclach
DELTA=203 (203 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Add fading text field cell
R=dmaclach,thomasvl
DELTA=161 (161 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add another window to the UILocalizer unittest that puts a bunch of
items into boxes, splitters, and scroll views to make sure they are
working.
Support some NSBox attributes in AppKit+UnitTesting.
Update the size to fit code to only special case regular push buttons and
not other types of buttons.
Update the expectations due to this change.
Add a new unittest to test all button styles and sizes.
Update how we decided to do vertical or horizontal layout on a width box
because left aligning things is visual and doesn't actually align their
frames, so instead we do a rect intersection instead.
Added in the CompilerSDK on Mac OS builds to the paths searches.
Update the comments on how paths are searched to be correct.
R=dmaclach,stuartmorgan
DELTA=2709 (2643 added, 8 deleted, 58 changed)
|
|
|
|
|
|
|
|
| |
Comment on one of the public UI points.
Put in another public UI point for tweaking UI without doing the
localization step (for non localization content tweaking).
R=stuartmorgan
DELTA=12 (11 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
missed the xib
R=stuartmorgan
DELTA=376 (376 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
| |
Update the textfield fixed width code to work with 10.5 (vs. 10.4 due to
a change on apple's end).
Add a unittest that captures the edge case.
R=stuartmorgan,dmaclach
DELTA=72 (66 added, 1 deleted, 5 changed)
|
|
|
|
|
|
|
| |
Not sure what I was thinking, sizes are CGFloats and it couldn't be unsigned
since the height to grow or shrink...
R=stuartmorgan
DELTA=2 (0 added, 0 deleted, 2 changed)
|