| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
|
|
|
|
|
|
| |
Remove GTMCGPointToNSPoint, GTMNSPointToCGPoint, GTMCGRectToNSRect, GTMCGSizeToNSSize
Note that Apple's NSGeometry.h sometimes defines
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
so there's some reason to believe the CG and NS structs can compile incompatibly.
Fix a typo in GTMSenTestCase.h
|
| |
|
| |
|
|
|
|
|
| |
GTMGarbageCollection. Remove GC build configs. Remove internal dependence on GTMObjectSingleton.
DELTA=447 (49 added, 296 deleted, 102 changed)
|
|
|
|
|
|
|
| |
sets an integral size.
When resizing labels it's possible to get fractional sizes. This CL fixes the problem by using integral values.
DELTA=17 (17 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Private fields are turned into hidden symbols with the 64bit runtime,
so classes that are not in the same dylib / framework as GTMUILocalizer cannot
access these fields otherwise.
This is for http://crbug.com/190508
DELTA=2 (1 added, 0 deleted, 1 changed)
|
|
|
| |
DELTA=26 (0 added, 0 deleted, 26 changed)
|
|
|
|
|
|
|
|
| |
Remove the GC support code.
Add the needed images for the iOS unittests under iOS 6.0.
Add a workspace file for the iPhone project.
R=dmaclach
DELTA=215 (85 added, 122 deleted, 8 changed)
|
|
|
|
|
|
|
| |
Properly support top level parent view.
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=86
R=sail
DELTA=2 (0 added, 1 deleted, 1 changed)
|
|
|
|
|
|
| |
Clean up all of our format string issues amongst some other fun stuff.
R=thomasvl
DELTA=167 (90 added, 8 deleted, 69 changed)
|
|
|
|
|
|
|
|
|
| |
Clean up some basic issues in GTM.
Also removes GTMUniqueFileObjectPathBasedOn which depended on mktemp which is
bad.
R=thomasvl
DELTA=55 (6 added, 32 deleted, 17 changed)
|
|
|
|
|
|
| |
Skip sending -class to to self in class methods.
R=dmaclach
DELTA=3 (0 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Fix up -wformat warnings that clang was reporting
crbug.com/115847
TBR=thomasvl
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
|
|
|
|
| |
Always uses the first element of the array for the sizeof calc rather then
hard coding the type. Fixes an error with newer compiler where we did
sizeof(NSColor) instead of sizeof(NSColor*).
Fix warning about assignment of variable to itself.
R=dmaclach
DELTA=5 (0 added, 0 deleted, 5 changed)
|
|
|
|
|
| |
Finish fixing up the tests on 10.6.7.
TBR=dmaclach
|
|
|
|
|
| |
Yes, 10.6.7 with the 10.4 SDK draws some things differently.
TBR=dmaclach
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix memory model by making all the outlets assign not retain.
The problem here is UIViewControllers will dump their view in low memory
and then reload next time it is needed. So someone hangs on to the
localizer for something else, it would keep the views also loaded, so this
way the localizer won't keep any of the objects it points to alive via a
retain. Note: the AppKit version sorta matches this since outlets aren't
retained by default.
Clear them in awakeFromNib since that is all they are needed for.
R=dmaclach
DELTA=19 (9 added, 0 deleted, 10 changed)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Support for localizing non datasource versions of NSComboxBox (http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=77).
- Fix up some category names.
- Avoid conflicting category names.
- Move placeholder string support down to NSTextField instead of NSSearchField.
- Support for NSTextField placeholder in unittesting state.
- Support for non datasource combobox values in unittesting state.
- Fix NSSegmentControl localization support.
- Add explicit tests for no localized values and document it in the strings file.
- Unittesting for as much as possible of the above.
R=dmaclach
DELTA=762 (660 added, 55 deleted, 47 changed)
|
|
|
|
|
|
| |
Add reference image for 10.6.8 since it seems the sizing of bezel buttons
changed.
TBR=dmaclach
|
|
|
|
|
|
| |
In GTM SizeToFit(), add more padding for NSTexturedRoundedBezelStyle buttons.
R=thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
| |
Switch to using the class methods +saveGraphicsState/+restoreGraphicsState.
R=mmentovai
APPROVED=dmaclach
|
|
|
|
|
|
| |
Fix typo.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up missing space.
R=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up test that didn't compile on SnowLeopard due to protocols.
TBR=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
|
| |
Adds a simple key value animation class. CAAnimation doesn't really allow
you to animate things that aren't part of CALayers, and this gets us 90%
of the way there to being able to not have to subclass NSAnimation for every
animation we want to do.
R=mikemorton
DELTA=155 (155 added, 0 deleted, 0 changed)
|
|
|
|
| |
path animation class based on NSAnimation
|
|
|
|
|
|
|
|
|
|
| |
Make implicit assumptions in GTMWindowSheetController explicit by
adding asserts.
Original review at http://codereview.appspot.com/4418041/
R=avi
APPROVED=avi
DELTA=8 (6 added, 0 deleted, 2 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Tweak fade effect for GTMFadeTruncatingTextFieldCell
This change tweaks how we fade the beginning of the text in GTMFadeTruncatingTextFieldCell. Previously we would start drawing the string at the desired position. This meant that the first character was not legible because of the fade effect. With this change we now start drawing a few pixels before the desired position.
I also fixed a bug in how we draw the background of the cell. Previously we clipped to the text rect before drawing the background. When the text field had a border this meant that we weren't drawing all of the background because the text rect is slightly smaller than the background rect. With this change we now draw the background rect before setting the text rect clip.
R=thomasvl,dmaclach
APPROVED=dmaclach
DELTA=81 (51 added, 2 deleted, 28 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Currently GTMFadeTruncatingTextFieldCell only supports truncating the tail of a string.
It should also allow the head of a string to be truncated.
I'd like to use this in Chromium. See http://crbug.com/69304
R=thomasvl
APPROVED=thomasvl
DELTA=238 (197 added, 17 deleted, 24 changed)
|
|
|
|
|
|
|
| |
Fix for building GTM on Snow Leopard.
We were getting errors for being unable to protect buffers smaller than 8 chars.
R=aharper,thomasvl
DELTA=7 (4 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Pull __weak modifier from variable whose value is actually owned.
R=thakis
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
|
| |
Fix a harmless clang warning about the self-assignment
duration = duration;
R=thomasvl
APPROVED=thomasvl
DELTA=6 (0 added, 1 deleted, 5 changed)
|
|
|
|
|
|
|
| |
Fix up GTMHotKeyTextField so that it compiles cleanly with format string warnings on.
Change to match other controls where string value always returns the empty string as opposed to nil.
R=thomasvl
DELTA=7 (4 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Allow adding a new sheet in a sheet's closing callback in GTMWindowSheetController. GTMWindowSheetController does not completely remove a sheet until after the callback has been invoked. This causes an assert to trigger if another sheet is launched in the callback, which is inconsistent with normal Cocoa sheets. Switch the order of the two operations and add a unit test. This affects http://crbug.com/56948 . Patch by davidben@chromium.org .
R=dmaclach
DELTA=112 (106 added, 5 deleted, 1 changed)
|
|
|
|
|
|
| |
Set resizing defaults for GTMLargeTypeWindow to something sane.
R=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Fix up GTMCarbonEvent to fix a major bug with comparing events.
Also increases error checking and makes debugging easier.
R=thomasvl
DELTA=18 (6 added, 0 deleted, 12 changed)
|
|
|
|
|
|
| |
Allow tabbing to move around dialog, and add a description method.
R=thomasvl
DELTA=11 (10 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
| |
GTMHotKeyTextField on 10.4 again, properties are too new, so write custom
accessors.
DELTA=47 (29 added, 18 deleted, 0 changed)
R=dmaclach
|
|
|
|
|
|
|
|
|
|
| |
Revamped GTMHotKeyTextField so that it is far more of the standard control/cell architecture.
Cells can now be used in tableviews.
Binding is done correctly.
You can now use the "delete" key to clear the hotkey field.
Generally simplified the interface.
R=thomasvl
DELTA=750 (154 added, 423 deleted, 173 changed)
|
|
|
|
|
|
| |
Clean up GTMCarbonEvent hotkey stuff to make it more usable.
R=thomasvl
DELTA=138 (59 added, 13 deleted, 66 changed)
|
|
|
|
|
|
| |
Fix up the GTM build due to problems with GTMULocalizer.
TBR=thomasvl
DELTA=1128 (713 added, 411 deleted, 4 changed)
|
|
|
|
|
|
|
|
| |
Add support for NSSegmentedControl to GTMUILocalizer.
This fixes http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=53.
R=dmaclach
APPROVED=dmaclach
DELTA=142 (137 added, 1 deleted, 4 changed)
|
|
|
|
|
|
| |
Fix up build machine issue.
TBR=thomasvl
DELTA=6 (3 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Turns on the undeclared-selector warning. This may cause builds to fail if they are using
our configs. Also cleaned up some whitespace issues.
R=thomasvl
DELTA=94 (71 added, 22 deleted, 1 changed)
|
|
|
|
|
|
| |
Another Leopard PCH casualty..
DELTA=0 (0 added, 0 deleted, 0 changed)
R=thomasvl
|
|
|
|
|
|
| |
Fix up build on Leopard.
R=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Cleans up builds of GTM on Snow Leopard with gcc 4.2.
Cleans up iPhone configs
Adds libgcov for Snow Leopard
Fixes up some small bugs.
R=thomasvl
DELTA=2028 (972 added, 990 deleted, 66 changed)
|
|
|
|
|
|
| |
Add missing files from previous checkin.
R=thomasvl
DELTA=0 (0 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
There are still a couple of errors occurring, but this fixes up the majority of stuff. I figured I'd send it out to you now to take
a look at in the morning, and then we can clean up the last couple of issues.
Not quite sure what to do about the naming of data files so that we can encompass ranges of system version (e.g. this file applies to
10.5 and 10.6 but not 10.4 or 10.7.
R=thomasvl
DELTA=10598 (10211 added, 70 deleted, 317 changed)
|