| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of code that Google stopped using/maintaining rather than trying
to update it it. Some would be hard to update, some actually has system provided
replacements; others are patterns that just don't seem as common now.
Prune out the code related to macOS <= 10.5, start pruning some of the really
old iOS support also.
Get the projects mostly limping again with modern Xcodes so tests can be run.
If someone ends up on this commit via history for something they still find
as useful, feel free to do a pull request to bring the snippet of code back to
life and update it for current SDKs.
|
| |
|
|
|
| |
Finish fixing up the tests on 10.6.7.
TBR=dmaclach
|
| |
|
|
|
| |
Yes, 10.6.7 with the 10.4 SDK draws some things differently.
TBR=dmaclach
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Support for localizing non datasource versions of NSComboxBox (http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=77).
- Fix up some category names.
- Avoid conflicting category names.
- Move placeholder string support down to NSTextField instead of NSSearchField.
- Support for NSTextField placeholder in unittesting state.
- Support for non datasource combobox values in unittesting state.
- Fix NSSegmentControl localization support.
- Add explicit tests for no localized values and document it in the strings file.
- Unittesting for as much as possible of the above.
R=dmaclach
DELTA=762 (660 added, 55 deleted, 47 changed)
|
| |
|
|
|
|
| |
Add reference image for 10.6.8 since it seems the sizing of bezel buttons
changed.
TBR=dmaclach
|
| |
|
|
|
|
|
|
|
|
|
| |
Tweak fade effect for GTMFadeTruncatingTextFieldCell
This change tweaks how we fade the beginning of the text in GTMFadeTruncatingTextFieldCell. Previously we would start drawing the string at the desired position. This meant that the first character was not legible because of the fade effect. With this change we now start drawing a few pixels before the desired position.
I also fixed a bug in how we draw the background of the cell. Previously we clipped to the text rect before drawing the background. When the text field had a border this meant that we weren't drawing all of the background because the text rect is slightly smaller than the background rect. With this change we now draw the background rect before setting the text rect clip.
R=thomasvl,dmaclach
APPROVED=dmaclach
DELTA=81 (51 added, 2 deleted, 28 changed)
|
| |
|
|
|
|
|
|
|
|
|
| |
Currently GTMFadeTruncatingTextFieldCell only supports truncating the tail of a string.
It should also allow the head of a string to be truncated.
I'd like to use this in Chromium. See http://crbug.com/69304
R=thomasvl
APPROVED=thomasvl
DELTA=238 (197 added, 17 deleted, 24 changed)
|
| |
|
|
|
|
| |
Fix up the GTM build due to problems with GTMULocalizer.
TBR=thomasvl
DELTA=1128 (713 added, 411 deleted, 4 changed)
|
| |
|
|
|
|
|
|
| |
Add support for NSSegmentedControl to GTMUILocalizer.
This fixes http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=53.
R=dmaclach
APPROVED=dmaclach
DELTA=142 (137 added, 1 deleted, 4 changed)
|
| |
|
|
|
|
|
|
|
| |
Cleans up builds of GTM on Snow Leopard with gcc 4.2.
Cleans up iPhone configs
Adds libgcov for Snow Leopard
Fixes up some small bugs.
R=thomasvl
DELTA=2028 (972 added, 990 deleted, 66 changed)
|
| |
|
|
|
|
| |
Add missing files from previous checkin.
R=thomasvl
DELTA=0 (0 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
|
|
|
| |
There are still a couple of errors occurring, but this fixes up the majority of stuff. I figured I'd send it out to you now to take
a look at in the morning, and then we can clean up the last couple of issues.
Not quite sure what to do about the naming of data files so that we can encompass ranges of system version (e.g. this file applies to
10.5 and 10.6 but not 10.4 or 10.7.
R=thomasvl
DELTA=10598 (10211 added, 70 deleted, 317 changed)
|
| |
|
|
|
|
|
|
| |
Don't trim the whitespace off the string when doing test sizing...
TextField does some odd stuff with whitespace when it does wrap things, if you don't include the white space, then when you use the real string (to wrap), it moves the last word down a line because of lack of space for the whitespace (go figure).
Oh, and fix the leak.
R=dmaclach
DELTA=6 (0 added, 1 deleted, 5 changed)
|
| |
|
|
|
|
| |
Add an api for forcing a NSTextField to a fixed height but what ever width is needed.
R=dmaclach
DELTA=634 (631 added, 0 deleted, 3 changed)
|
| |
|
|
|
|
| |
Add basic support for NSTabView and a unittest to validate simple behaviors.
R=dmaclach
DELTA=1069 (1066 added, 0 deleted, 3 changed)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=40.
Sets up GTMUILocalizer to localize some bindings. Handles:
NSMultipleValuesPlaceholderBindingOption
NSNoSelectionPlaceholderBindingOption
NSNotApplicablePlaceholderBindingOption
NSNullPlaceholderBindingOption
NSDisplayNameBindingOption,
NSDisplayPatternBindingOption,
R=thomasvl
DELTA=1475 (815 added, 596 deleted, 64 changed)
|
| |
|
|
|
|
|
|
|
| |
Nicer drawing of text by not using the gradient where it isn't needed,
helps where light text is drawn on a dark background.
Patch from thakis - http://codereview.appspot.com/159060/show
R=thakis,dmaclach
DELTA=79 (54 added, 7 deleted, 18 changed)
|
| |
|
|
|
|
|
|
| |
Add a helper for doing view resizing without resizing subviews.
Fix the fixed width call to not change the width.
Update the unittest to make sure the fixed width call doesn't change the width.
R=stuartmorgan,dmaclach
DELTA=41 (30 added, 0 deleted, 11 changed)
|
| |
|
|
|
|
|
| |
Add two apis for making checkboxs/radios and radio groups wrap to their size.
Add a unittest to cover normal and mini sizes.
R=dmaclach,stuartmorgan
DELTA=1174 (1164 added, 0 deleted, 10 changed)
|
| |
|
|
|
|
|
|
|
|
| |
Support the toolbar item's view in state logging.
Add table columns to ui localizer (tests will come in a following cl).
Add a toolbar item that doesn't localize to help catch bugs in the future like we had on first impl.
Add a tooltip to the toolbar item in the unittest for ui localizer.
Add a note about the limits to ui localizer and toolbars due to the NSToolbar api's limits.
R=dmaclach
DELTA=746 (90 added, 599 deleted, 57 changed)
|
| |
|
|
|
|
| |
Fix up GTMUILocalizerTest which wasn't finding the nib with . in the name appropriately.
R=thomasvl,alcor
DELTA=5468 (2729 added, 2729 deleted, 10 changed)
|
| |
|
|
|
|
| |
Fix toolbar localizer test
R=thomasvl
DELTA=2780 (2767 added, 6 deleted, 7 changed)
|
| |
|
|
|
|
|
|
| |
Update Large UI with latest nib
Add toolbar to prefs
Add toolbar localization
R=dmaclach
DELTA=4125 (3054 added, 462 deleted, 609 changed)
|
| |
|
|
|
|
| |
Add fading text field cell
R=dmaclach,thomasvl
DELTA=161 (161 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add another window to the UILocalizer unittest that puts a bunch of
items into boxes, splitters, and scroll views to make sure they are
working.
Support some NSBox attributes in AppKit+UnitTesting.
Update the size to fit code to only special case regular push buttons and
not other types of buttons.
Update the expectations due to this change.
Add a new unittest to test all button styles and sizes.
Update how we decided to do vertical or horizontal layout on a width box
because left aligning things is visual and doesn't actually align their
frames, so instead we do a rect intersection instead.
Added in the CompilerSDK on Mac OS builds to the paths searches.
Update the comments on how paths are searched to be correct.
R=dmaclach,stuartmorgan
DELTA=2709 (2643 added, 8 deleted, 58 changed)
|
| |
|
|
|
|
|
|
| |
Update the textfield fixed width code to work with 10.5 (vs. 10.4 due to
a change on apple's end).
Add a unittest that captures the edge case.
R=stuartmorgan,dmaclach
DELTA=72 (66 added, 1 deleted, 5 changed)
|
| |
|
|
|
|
|
| |
Bump up the min size on buttons with a note about the logic, update the
unittest images accordingly.
R=stuartmorgan
DELTA=9 (3 added, 0 deleted, 6 changed)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Move the nib finding code in GTMUILocalizer to a class methods so it can
be called without an instance.
Add GTMUILocalizerAndLayoutTweaker getting UI localized and then running
through it to auto size UI items that have been marked and also support
limited tweaks on other objects based on a group of tweaks.
Provide a class method for this sizeToFit fixup of individual objects.
Unittests for the new class.
R=dmaclach,stuartmorgan
DELTA=3161 (3157 added, 0 deleted, 4 changed)
|
| |
|
|
|
|
| |
changing the encoding and project out of sync seems to have messed things up, fixing.
R=dmaclach
DELTA=36 (35 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
|
|
| |
Support for NSMatrix in uistate files (dumps the cells and row/column counts).
Support for NSMatrix in GTMUILocalizer.
Added checkboxes and radio groups to the GTMUILocalizer unittest.
R=dmaclach
DELTA=551 (541 added, 0 deleted, 10 changed)
|
| |
|
|
|
|
|
| |
Fixed up GTMUILocalizer to work properly with popup menus and alternate titles.
Fixed up UnitTesting code to check for it.
R=thomasvl
DELTA=3175 (3151 added, 14 deleted, 10 changed)
|
| |
|
|
|
|
| |
Added GTMUILocalizer for localizing UIs. 100% code coverage from tests.
DELTA=1956 (1940 added, 8 deleted, 8 changed)
R=thomasvl
|
| |
|
|
|
|
| |
Should fix up Unittests.
DELTA=0 (0 added, 0 deleted, 0 changed)
R=avi,thomasvl
|
| |
|
|
|
| |
Add ability to create rounded rects with different radii for different corners.
R=dmaclach
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
way for all GTM code to do it.
- Added GTMDebugThreadValidation to allow you to enforce the fact that your
code must run in the main thread in DEBUG builds.
- Updated some internals of the iPhone unittesting so it doesn't double print
the test descriptions, file names, or lines numbers of a test failure line.
Also includes the test names in the error output.
- Changed the xcconfigs so that know it's easier to set different settings at
the different levels and not accidentally overwrite settings set at lower
levels in the "settings collapse". Also tightened up warnings significantly.
- Changed how gtm_unitTestExposedBindingsTestValues works. If you have an
implementation of gtm_unitTestExposedBindingsTestValues in your own code
you will need to update to the new way of calling. See implementations in
GTMNSObject+BindingUnitTesting.m for details.
- Added support for grabbing the build number for a particular OS in
GTMSystemVersion and easily comparing it to known build numbers, and switched
some types from in GTMSystemVersion from "int" to SInt32 to make 64 bit work
better.
- Added support for SnowLeopard (10A96). We build cleanly with the 10.6 SDKs and
all radar checks were updated accordingly. Build All script was also updated
to build on SnowLeopard if you have the SDK available.
- Turned off building ppc64 GTM because the SnowLeopard SDK currently
doesn't have ppc64 support, so SenTestCase isn't defined. This makes it
impossible to build the ppc64 10.5 config on SnowLeopard. We have left the
setting in the xcconfig for those of you who need it, but have disabled
it in the GTM project settings.
- Turned on stack smashing protection on the debug builds for all Leopard
and above.
- Added ability to easily do leak checking by defining the GTM_ENABLE_LEAKS
environment variable. It isn't on by default because several of Apple's
frameworks leak. You can work around these false positives by using the
GTM_LEAKS_SYMBOLS_TO_IGNORE environment variable. Also if you turn on leaks
make sure to turn off zombies by defining the GTM_DISABLE_ZOMBIES variable,
otherwise every memory allocation you do will look like a leak.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added GTMCFAutorelease to make the [GTMNSMakeCollectable(cfFoo) autorelease] simpler and clearer, it's now just GTMCFAutorelease(cfFoo), and works in both GC and non-GC world.
- Added GTMIsGarbageCollectionEnabled to GTMGarbageCollection.h. See the note there for it's usage.
- Disabled the unittests for things on top of NSAppleScript in a GC world since Apple has bugs and it can crash. See the unittest for a note about it.
- GTMStackTrace now can figure out ObjC symbols. Downside it is now ObjC only.
- GTMFourCharCode can now be used with NSAppleEventDescriptors easily. typeType, typeKeyword, typeApplSignature, and typeEnumerated all get turned into GTMFourCharCodes.
- Fixed up crash in GTMLoggerRingBufferWriter when used with GC on.
- Significant updates to GTMNSAppleScript+Handler allowing you to list all handlers and properties (including inherited) and cleans up several errors in how scripting was being handled.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixed up GTMIPhoneUnitTestDelegate to be pickier about which tests it runs
- Added GTMNSString+URLArguments to GTMiPhone
- Added GTMHTTPFetcher and GTMHTTPServer to GTMiPhone
- Made sure that build would work with iPhone device attached, and that all
tests run directly on the phone.
- Added GTMValidatingContainers which are a set of mutable container classes
that allow you to have a selector on a target that is called to verify that
the objects being put into the container are valid. This can be controlled
at compile time so that you don't take the performance hit in a release build.
- Added GTMPath, which represents an existing absolute path on the file system.
It also makes it very easy to contruct new paths in the file system as well
as whole directory hierarchies.
- Added GTMNSString+Replace for a common replacement need.
- Added NSString+FindFolder for two commen helpers for building paths to common
locations.
- Added GTMLargeTypeWindow for doing display windows similar to Address Book
Large Type display for phone numbers.
|
|
|
Added some more xcode configs related to the above.
Removed some classes that the unittesting doesn't need (and aren't able to
support 64bit).
add base64, httpfetcher, and progress monitor stream.
|
dmaclach
gtm.daemon
thomasvl@gmail.com
thomasvl