| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
- Create shared scheme to use.
- Let Xcode (9.4.1) update the project files and add some warnings.
- Remove -finalize (GC days are gone)
- Add some more pragmas to compile cleanly.
- The iOS targets had a mix of 7.0 and 8.0 min versions, so make them
all 8.
|
|
|
| |
Tests and code all build and run with no warnings.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Properly support top level parent view.
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=86
R=sail
DELTA=2 (0 added, 1 deleted, 1 changed)
|
|
|
|
|
|
|
|
|
|
| |
Make implicit assumptions in GTMWindowSheetController explicit by
adding asserts.
Original review at http://codereview.appspot.com/4418041/
R=avi
APPROVED=avi
DELTA=8 (6 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Pull __weak modifier from variable whose value is actually owned.
R=thakis
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Allow adding a new sheet in a sheet's closing callback in GTMWindowSheetController. GTMWindowSheetController does not completely remove a sheet until after the callback has been invoked. This causes an assert to trigger if another sheet is launched in the callback, which is inconsistent with normal Cocoa sheets. Switch the order of the two operations and add a unit test. This affects http://crbug.com/56948 . Patch by davidben@chromium.org .
R=dmaclach
DELTA=112 (106 added, 5 deleted, 1 changed)
|
|
|
|
|
|
| |
Typo fix in selector name.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
| |
Added some basic casting debugging goodness to GTM.
Opinions? added to help catch a bug in QSB.
R=thomasvl
DELTA=55 (55 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Use class membership instead of string match.
R=mmentovai,avi
DELTA=6 (3 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Unset focus when hiding a per-tab sheet.
This is necessary so that when switching to a new tab using the
cmd-alt-right keyboard shortcut in chromium, the sheet in the previous
tab doesn't keep keyboard focus (which makes breaks cmd-l etc until the
window is clicked -- annoying).
R=thomasvl
DELTA=5 (5 added, 0 deleted, 0 changed)
|
|
Adding the WindowSheetController to GTM.
R=dmaclach
DELTA=925 (925 added, 0 deleted, 0 changed)
|