| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Reverting changes for launching tests due to some errors not seen in
testing before hand.
TBR=dmaclach
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Overhaul how iOS unittests are run.
Newer versions of Xcode have changes in the Simulator and supporting
frameworks so the way GTM had been running unittests no longer works.
The Simulator frameworks bail on launch with a zero exit code, so unless
you look at the raw output, you don't even notice the tests no longer
run.
This new way comes from the work done in Chromium to actually launch the
unittests fully under the simulator to get them a much more realistic
environment. It also takes what was learned there about getting the output
of the binary and how to deal with all the different ways a test and the
simulator can fail to start along with all the different ways the failures/
crashing of the app can come back.
There are some new env variables that let you force a version of the
simulator (assuming it is installed) along with one to say if you want to
run under iPhone or iPad.
- Land a copy of the Chromium iossim util.
- Convert RunIPhoneUnitTest over to use iossim.
R=dmaclach
DELTA=201 (79 added, 77 deleted, 45 changed)
|
|
|
|
|
|
|
|
|
|
|
| |
Fix error-case memory leak in GTMSMJobRemove.
GTMPerformOnLabel will create an error in &local_error when it returns
NULL, so there is no need to create yet another error in local_error.
It masks the error created by GTMPerformOnLabel, which is leaked.
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=2 (0 added, 2 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
|
| |
10.8 SDK compatibility for GTM.
|Object| is gone in Objective-C 2 in the 10.8 SDK, use |NSObject|
instead as for iOS.
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=5 (2 added, 0 deleted, 3 changed)
|
|
|
|
|
|
|
| |
Remove analyzer warning for returning released memory.
R=thomasvl
APPROVED=thomasvl
DELTA=4 (4 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up string to match. Probably a stray delete we missed.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up final GTM issues that I know of for format.
TBR=thomasvl
DELTA=16 (16 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up another case of bad format string handling by various versions of Xcode.
R=thomasvl
DELTA=15 (15 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Fix up GTM for Xcode 4.2
R=thomasvl
DELTA=9 (9 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Turn off warnings on gcc. Leave them on on clang.
R=thomasvl
DELTA=32 (30 added, 2 deleted, 0 changed)
|
|
|
|
|
| |
Fix up one more format string
TBR=dmaclach
|
|
|
|
|
|
|
| |
Clean up GTMSenTestCase so that the format strings work correctly
Get rid of a lot of bad whitespace.
TBR=thomasvl
DELTA=218 (0 added, 0 deleted, 218 changed)
|
|
|
|
|
|
|
| |
removing inconsistent and confusing URLWithString method
R=dmaclach
APPROVED=dmaclach
DELTA=26 (0 added, 21 deleted, 5 changed)
|
|
|
|
|
|
| |
Some more google toolbox cleanup.
TBR=thomasvl
DELTA=25 (6 added, 2 deleted, 17 changed)
|
|
|
|
|
|
| |
Remove some more per file compiler flags that shouldn't be needed now.
R=dmaclach
DELTA=4 (0 added, 0 deleted, 4 changed)
|
|
|
|
|
|
| |
Clean up all of our format string issues amongst some other fun stuff.
R=thomasvl
DELTA=167 (90 added, 8 deleted, 69 changed)
|
|
|
|
|
|
|
| |
Add a CPP gate to prevent the install of the atexit hook for running
leaks.
R=dmaclach
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Disable COPY_PHASE_STRIP so we don't corrupt signed binaries.
R=dmaclach,thomasvl
APPROVED=thomasvl
|
|
|
|
|
|
| |
Add Quaternions to our list of things the GTMSenTestCase can handle.
R=fvaucher
DELTA=3 (3 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Add header back in attempt to fix build.
TBR=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
|
|
| |
Clean up some basic issues in GTM.
Also removes GTMUniqueFileObjectPathBasedOn which depended on mktemp which is
bad.
R=thomasvl
DELTA=55 (6 added, 32 deleted, 17 changed)
|
|
|
|
|
|
|
|
|
|
| |
fix some type errors.
Tested:
Compiled and ran a text program
R=thomasvl
APPROVED=thomasvl
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
| |
Fix place attributes aren't passed for older Mac OS versions.
TBR=dmaclach
|
|
|
|
|
| |
Remove the format on the impl, older compilers don't like it.
TBR=mikemorton
|
|
|
|
|
| |
Missing semi for old Mac OS SDKs.
TBR=dmaclach
|
|
|
|
|
|
| |
Small fixes for iOS.
R=dmaclach
DELTA=8 (0 added, 2 deleted, 6 changed)
|
|
|
|
|
| |
Fix wrong CPP gate.
TBR=dmaclach
|
|
|
|
|
|
| |
Removing the checks until I can test with more local builds to confirm
it works, to many combinations that can break it seems.
TBR=dmaclach
|
|
|
|
|
| |
One more shot at working with older compilers.
TBR=dmaclach
|
|
|
|
|
| |
Trying to fix things for older compilers.
TBR=dmaclach
|
|
|
|
|
|
| |
Pile of fixes for trunk version of clang.
R=dmaclach
DELTA=59 (26 added, 0 deleted, 33 changed)
|
|
|
|
|
|
|
| |
Macro for invalidating initializers.
R=dmaclach
APPROVED=dmaclach
DELTA=18 (18 added, 0 deleted, 0 changed)
|
|
|
|
|
|
|
| |
Expose internal GTMLogger logging method for subclasses to override.
R=thomasvl
APPROVED=thomasvl
DELTA=20 (9 added, 10 deleted, 1 changed)
|
|
|
|
|
|
|
| |
-Forward SYMROOT and friends in BuildUsingXCodeBuild.sh. They appear to be required in order for projects that #import generated files from sub-projects.
R=thomasvl
APPROVED=thomasvl
DELTA=6 (5 added, 0 deleted, 1 changed)
|
|
|
|
|
|
|
|
| |
-Add logic to RunIPhoneUnitTest.sh to allow skipping tests based on the TEST_AFTER_BUILD variable
-Add a script to GTM for running the active target using xcodebuild, and enabling TEST_AFTER_BUILD.
R=thomasvl
APPROVED=thomasvl
DELTA=52 (51 added, 0 deleted, 1 changed)
|
|
|
|
|
| |
Add support for doing asserts on GLK types (GLKVector*, GLKMatrix*)
R=thomasvl
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change RunIPhoneUnitTest.sh to launch securityd directly.
This fixes a bug where keychain library functions called from unit tests
would fail after a period of inactivity. We will now launch the security
daemon via launchctl load with a custom plist configuration, rather than
via RunIPhoneLaunchDaemons.sh.
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=159 (112 added, 44 deleted, 3 changed)
|
|
|
|
|
|
| |
Implement sel_isEqual
R=dmaclach
APPROVED=dmaclach
|
|
|
|
|
|
|
| |
SDK might allow blocks, but the code the test calls requires it (and 10.5
thread apis), so instead check the min versions before building the test.
R=dmaclach
DELTA=3 (0 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Fix build for older SDKs.
Rename parameter to avoid issue with extra compiler flags.
TBR=dmaclach
|
|
|
|
|
|
| |
Add a blocks API to NSThread.
R=thomasvl,grobbins
DELTA=238 (236 added, 1 deleted, 1 changed)
|
|
|
|
|
|
| |
Fix up gate to match the ones above for handling older OS versions.
R=dmaclach
DELTA=2 (0 added, 0 deleted, 2 changed)
|
|
|
|
|
|
| |
Tweak to what archs we default.
R=dmaclach
DELTA=6 (0 added, 2 deleted, 4 changed)
|
|
|
|
|
|
| |
Skip sending -class to to self in class methods.
R=dmaclach
DELTA=3 (0 added, 0 deleted, 3 changed)
|
|
|
|
|
|
| |
Flexible builder for URLs.
R=altse,dmaclach,thomasvl
APPROVED=dmaclach
|
|
|
|
|
|
| |
Add better error handling.
R=thomasvl
DELTA=13 (0 added, 0 deleted, 13 changed)
|
|
|
|
|
|
|
| |
Fix typo on test name so it wasn't running.
Fix the loops to use compression level 9 also.
R=dmaclach
DELTA=4 (0 added, 0 deleted, 4 changed)
|
|
|
|
|
|
|
| |
Allow the GTMLogger macros to be remapped in a prefix by checking if they
are defined before defining them.
R=dmaclach
DELTA=5 (5 added, 0 deleted, 0 changed)
|
|
|
|
|
|
| |
Add support for raw inflate/deflate without a header.
R=dmaclach
DELTA=416 (327 added, 69 deleted, 20 changed)
|
|
|
|
|
|
|
| |
Fix up -wformat warnings that clang was reporting
crbug.com/115847
TBR=thomasvl
DELTA=2 (0 added, 0 deleted, 2 changed)
|