| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
|
| |
There was a race between the thread being finished and
isFinished/isExecuting reporting correctly.
There may have also been a locking issue on older single processor phones.
|
|
|
| |
It should all be replaced with XCTestExpectations.
|
| |
|
|
|
|
| |
There were quotes around the test harness path in the project that was making
it so Xcode couldn't find it to run it.
|
|
|
|
|
| |
This was causing errors when building with Xcode 10 and XCTest.
XCTest defines a bunch of macros starting with _[A-Z] that were
setting off the error when building for the Mac.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit 585330a68d00c4d76927ff7bf4829471944358ab.
|
|
|
|
|
|
|
| |
Basically a complete rewrite of GTMSimpleWorkerThread that should get rid of a race condition
when stopping tests and testing for "isExecuting/isFinished".
It does change the observed behaviour of GTMSimpleWorkerThread a little in that "start" no longer
blocks until the thread is starting, and we removed the unused "stop" method.
|
|
|
|
|
| |
- Set up stack trace test just so we make sure we don't recurse. Right now it is too tight and breaks on every system release.
- SQLite's behavior is actually undefined in the case of sqlite3_errcode, so don't depend on it in a test.
|
| |
|
| |
|
|
|
|
|
|
|
| |
ubsan output:
.../google_toolbox_for_mac/Foundation/GTMStringEncoding.m:204:16: runtime error: left shift of 10368305 by 8 places cannot be represented in type 'int'
.../google_toolbox_for_mac/Foundation/GTMStringEncoding.m:312:16: runtime error: left shift of 42406098 by 6 places cannot be represented in type 'int'
TESTED=Earth iOS --featires=ubsan
|
| |
|
|
|
|
|
|
|
| |
- Keep Gestalt APIs till 10.8.
- On 10.8 and 10.9 use sysctl and infer the OS version from there.
- On 10.10+ use NSProcessInfo.
- Added unit test to cover it.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
- Disable GTMURLBuilderTest since there are system apis to use at
iOS 8+.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In https://crbug.com/747643, a new version of Clang produces warnings
when attempting to format NSInteger as %zd (which is normally used for
ssize_t). Acquiesce by casting NSInteger to long and formatting using
%ld.
In the process, I audited all occurrences of %zd in GTM and found that
the remainder were being used to format size_t, which ought to use %zu,
so I’ve corrected those.
I also audited the existing uses of %zu and found them all to be
correct.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting in the 10.6 SDK, the non-underscored and all-lowercase macro
names in <AssertMacros.h> were deprecated. In the 10.13 SDK shipping in
Xcode 9 beta 3 (but not previous betas of Xcode 9), Apple has made good
on its promise to eventually disable these names. Update GTM to use the
new underscored mixed-case names.
Provided that nobody needs to target anything older than the 10.5 SDK
anymore, this should be a safe change.
Aside from GTMCarbonEvent.m, which is used by Chrome, this change is
untested, and was made by mechanically replacing uses of the various
check, require, and verify macros found in GTM.
|
|
|
|
| |
This has come up on issues #130 and #138.
|
|
|
|
| |
Same as what is in UnitTesting/GTMIPhoneUnitTestMain.m.
|
| |
|
|
|
|
| |
Added -Wreserved-id-macro and but exclude existing nonconforming macros
|
|
|
|
| |
Fixed PodSpec for tvOS
|
|
|
|
| |
Support for tvOS
|
|\
| |
| | |
Remove trailing whitespaces
|
|/ |
|
|\
| |
| | |
Change include to import for GTMDefines
|
|/ |
|
|\
| |
| | |
Change file type from UTF16 to ASCII
|
|/ |
|