| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will need followup, but this is a quick and dirty to fix the things
that have gone very stale.
- Stop setting mac min sdk for iOS, there is an iOS version now (and
setting it can cause linker errors on newer xcodes).
- Add iOS xcconfigs that use the current SDK and have projects set their
min version as that's how Apple wants things.
- Add new config that uses the current SDK to make development workable.
- Block codesigning on the iOS unittests for now.
- Block format string warnings on logger until we can sort out a way to
shut it up for gcc 4.2 or actually make it work.
R=dmaclach
DELTA=289 (277 added, 3 deleted, 9 changed)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launchctl on Mac OS X 10.7 ("Lion") requires launchd plist pathnames
to end in ".plist".
Files that don't end in plist result in launchctl printing this
message and ignoring the file:
launchctl: Dubious file. Not of type .plist (skipping):
/tmp/GTMServiceManagement.W3Pz4K
http://crbug.com/93274
R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=3 (1 added, 1 deleted, 1 changed)
|
| |
|
|
|
|
| |
We'll try to do without the ARC macros, as encouraged by Apple.
R=thomasvl
APPROVED=thomasvl
|
| |
|
|
|
|
| |
Add ARCMacros for use in code that may compile with or without ARC enabled.
R=thomasvl,dmaclach
APPROVED=thomasvl
|
| |
|
|
|
|
| |
Fix duplicated test
R=thomasvl
APPROVED=thomasvl
|
| |
|
|
|
|
| |
Add a log filter that filters by simple level comparisons.
R=dmaclach,thomasvl
APPROVED=dmaclach
|
| |
|
|
|
|
|
| |
Running iOS unit tests outside of applicationDidFinishLaunching:
R=dmaclach,thomasvl
APPROVED=dmaclach
DELTA=12 (12 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
| |
In GTM SizeToFit(), add more padding for NSTexturedRoundedBezelStyle buttons.
R=thomasvl
APPROVED=thomasvl
|
| |
|
|
|
|
| |
Switch to using the class methods +saveGraphicsState/+restoreGraphicsState.
R=mmentovai
APPROVED=dmaclach
|
| |
|
|
|
|
| |
Fix up release decl so that clang doesn't complain.
R=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
| |
Fix typo.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
| |
Fix up missing space.
R=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
| |
Fix up test that didn't compile on SnowLeopard due to protocols.
TBR=thomasvl
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
|
|
|
| |
Adds a simple key value animation class. CAAnimation doesn't really allow
you to animate things that aren't part of CALayers, and this gets us 90%
of the way there to being able to not have to subclass NSAnimation for every
animation we want to do.
R=mikemorton
DELTA=155 (155 added, 0 deleted, 0 changed)
|
| |
|
|
| |
path animation class based on NSAnimation
|
| |
|
|
|
|
|
|
|
| |
Logging doesn't get to call assert() or exit() even when its very sad. Logging
isn't in charge of killing the process. Internal exceptions need catching too.
Plus some minor cleanup along the way, and better handling of
GTMVerboseLogging in the environment.
R=dmaclach,thomasvl
APPROVED=thomasvl
|
| |
|
|
|
|
|
| |
Get rid of warning in debug mode (%d used for NSUInteger). Just use
%lu instead and cast to unsigned long (largest NSUInteger can be).
R=dmaclach
APPROVED=dmaclach
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix ASL logging to reference the correct formatter (and then replace with
a new formatter).
- Format ASL messages to include information that would normally be present
in the standard formatter.
- Allow ASL writers to pass a facility string.
- Pretty up the function names in all logging, better matching NSAssert()
names (as one example).
- Don't throw if a logging filehandle is closed (SIGPIPE). Random exceptions
from logging is bad, m'kay?
R=thomasvl,dmaclach
APPROVED=thomasvl
|
| |
|
|
|
|
|
|
|
|
| |
Make implicit assumptions in GTMWindowSheetController explicit by
adding asserts.
Original review at http://codereview.appspot.com/4418041/
R=avi
APPROVED=avi
DELTA=8 (6 added, 0 deleted, 2 changed)
|
| |
|
|
|
|
|
|
|
|
|
| |
Tweak fade effect for GTMFadeTruncatingTextFieldCell
This change tweaks how we fade the beginning of the text in GTMFadeTruncatingTextFieldCell. Previously we would start drawing the string at the desired position. This meant that the first character was not legible because of the fade effect. With this change we now start drawing a few pixels before the desired position.
I also fixed a bug in how we draw the background of the cell. Previously we clipped to the text rect before drawing the background. When the text field had a border this meant that we weren't drawing all of the background because the text rect is slightly smaller than the background rect. With this change we now draw the background rect before setting the text rect clip.
R=thomasvl,dmaclach
APPROVED=dmaclach
DELTA=81 (51 added, 2 deleted, 28 changed)
|
| |
|
|
|
|
| |
Wrap the header so it compiles right if included in a C++ file.
R=dmaclach
DELTA=6 (6 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
|
|
|
|
|
| |
Currently GTMFadeTruncatingTextFieldCell only supports truncating the tail of a string.
It should also allow the head of a string to be truncated.
I'd like to use this in Chromium. See http://crbug.com/69304
R=thomasvl
APPROVED=thomasvl
DELTA=238 (197 added, 17 deleted, 24 changed)
|
| |
|
|
|
|
|
| |
Fix up case where we were picking up an invalid errno value when the child process
was exiting with a bad exit status.
TBR=thomasvl
DELTA=9 (3 added, 0 deleted, 6 changed)
|
| |
|
|
|
|
| |
Fix up HORRIBLE bug closing bad file descriptors.
R=thomasvl
DELTA=5 (1 added, 0 deleted, 4 changed)
|
| |
|
|
|
|
|
|
| |
Replicate project structure in the filesystem to maintain API and demo
separation.
Add p4_depot_paths.
R=burdon
DELTA=559 (340 added, 202 deleted, 17 changed)
|
| |
|
|
|
|
|
|
| |
Fix interaction of GTMFileSystemKqueue when the runloop isn't spinning. Also,
don't count on kCFSocketReadCallBack to keep calling us, empty the queue
whenever we can.
DELTA=93 (84 added, 0 deleted, 9 changed)
R=dmaclach,thomasvl
|
| |
|
|
|
|
| |
Works around a compiler bug on x86_64.
R=thomasvl
DELTA=9 (1 added, 1 deleted, 7 changed)
|
| |
|
|
|
|
|
| |
Fix for building GTM on Snow Leopard.
We were getting errors for being unable to protect buffers smaller than 8 chars.
R=aharper,thomasvl
DELTA=7 (4 added, 0 deleted, 3 changed)
|
| |
|
|
|
|
| |
Pull __weak modifier from variable whose value is actually owned.
R=thakis
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
|
|
|
| |
Fix a harmless clang warning about the self-assignment
duration = duration;
R=thomasvl
APPROVED=thomasvl
DELTA=6 (0 added, 1 deleted, 5 changed)
|
| |
|
|
|
|
|
| |
Turn off echoing of commands to avoid some of the chatter in Xcode (since it shows everything now)
Move where the memory tracing environment variables are set to avoid tracing the commands run before the test (as much as possible).
R=dmaclach
DELTA=109 (62 added, 45 deleted, 2 changed)
|
| |
|
|
|
|
|
|
| |
Fixes up build problem on gcc 4.0 release with Xcode 3.2.5
where it doesn't deal with "interesting" ascii in @"" constants
very well.
DELTA=35 (29 added, 0 deleted, 6 changed)
R=thomasvl
|
| |
|
|
|
|
|
| |
Add include for objc/message.h as objc/runtime on the iOS SDK doesn't include it
so objc_msgSend symbol is not explicitly included.
R=thomasvl
DELTA=1 (1 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Prep GTM for building on Snow Leopard.
Unfortunately our Snow Leopard build agents only support the latest SDKs, which is 3.2
and 4.1 right now, so I've had to:
- Add support for 4.1.
- Remove support for other iPhone configurations.
R=thomasvl
DELTA=320 (247 added, 63 deleted, 10 changed)
|
| |
|
|
|
|
| |
Add a cast to fix compiler warnings in release builds.
TBR=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
| |
Ensure main() always exists to avoid link errors.
TBR=dmaclach
DELTA=5 (2 added, 3 deleted, 0 changed)
|
| |
|
|
|
|
|
| |
Move the CPP guard before the system headers, they don't all exist on 10.4,
so compile was failing.
TBR=dmaclach
DELTA=5 (3 added, 2 deleted, 0 changed)
|
| |
|
|
|
|
|
|
|
| |
Move the test for abstract unittest support out into a file that can be
shared with iOS.
Add the unittest to the iOS project.
Fix up the iOS unittesting support to handle abstract tests.
R=dmaclach
DELTA=156 (105 added, 20 deleted, 31 changed)
|
| |
|
|
|
|
|
| |
Fix a few warning in release mode, when _GTM* expands to not use it's arguments.
R=thomasvl,sharvil
APPROVED=sharvil
DELTA=6 (6 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
|
| |
Fix up GTMHotKeyTextField so that it compiles cleanly with format string warnings on.
Change to match other controls where string value always returns the empty string as opposed to nil.
R=thomasvl
DELTA=7 (4 added, 0 deleted, 3 changed)
|
| |
|
|
|
|
| |
Clean up GTMServiceManagement when compiling 64 bit.
R=thomasvl
DELTA=5 (1 added, 0 deleted, 4 changed)
|
| |
|
|
|
|
| |
Allow adding a new sheet in a sheet's closing callback in GTMWindowSheetController. GTMWindowSheetController does not completely remove a sheet until after the callback has been invoked. This causes an assert to trigger if another sheet is launched in the callback, which is inconsistent with normal Cocoa sheets. Switch the order of the two operations and add a unit test. This affects http://crbug.com/56948 . Patch by davidben@chromium.org .
R=dmaclach
DELTA=112 (106 added, 5 deleted, 1 changed)
|
| |
|
|
|
|
|
| |
Clean up GTMServiceManagement so that it works with sockets.
Add better tests.
R=thomasvl
DELTA=478 (303 added, 109 deleted, 66 changed)
|
| |
|
|
|
|
| |
We dropped these a long time ago, but apparently one header got left behind.
R=dmaclach
DELTA=22 (0 added, 22 deleted, 0 changed)
|
| |
|
|
|
|
| |
Add URITemplate support.
R=dmaclach
DELTA=1084 (1083 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
| |
Set resizing defaults for GTMLargeTypeWindow to something sane.
R=thomasvl
DELTA=2 (2 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
| |
Fix up leak found by clang.
R=thomasvl
DELTA=5 (5 added, 0 deleted, 0 changed)
|
| |
|
|
|
|
| |
Clean up GTMServiceManagement under clang.
R=thomasvl
DELTA=28 (12 added, 4 deleted, 12 changed)
|
| |
|
|
|
|
| |
Fix up endif to match.
R=dmaclach
DELTA=1 (0 added, 0 deleted, 1 changed)
|
| |
|
|
|
|
|
| |
GTM_PROPERTY Macro defined to make working with
willChangeValueForKey: and didChangeValueForKey: safer.
R=thomasvl
DELTA=13 (13 added, 0 deleted, 0 changed)
|
gtm.daemon
dmaclach