[Author: thomasvl]

Add another window to the UILocalizer unittest that puts a bunch of
  items into boxes, splitters, and scroll views to make sure they are
  working.
Support some NSBox attributes in AppKit+UnitTesting.
Update the size to fit code to only special case regular push buttons and
  not other types of buttons.
Update the expectations due to this change.
Add a new unittest to test all button styles and sizes.
Update how we decided to do vertical or horizontal layout on a width box
  because left aligning things is visual and doesn't actually align their
  frames, so instead we do a rect intersection instead.
Added in the CompilerSDK on Mac OS builds to the paths searches.
Update the comments on how paths are searched to be correct.

R=dmaclach,stuartmorgan
DELTA=2709  (2643 added, 8 deleted, 58 changed)

11 files changed, 305 insertions, 0 deletions

diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-0.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-0.tiff
index a0108e2..86814a3 100644
--- a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-0.tiff
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-0.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-1.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-1.tiff
index a9e1604..31a44ba 100644
--- a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-1.tiff
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-1.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-2.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-2.tiff
index 9e9adf7..b4c2375 100644
--- a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-2.tiff
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest1-2.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.10_4_SDK.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.10_4_SDK.tiff
new file mode 100644
index 0000000..62ff8a1
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.10_4_SDK.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.tiff
new file mode 100644
index 0000000..252ee9a
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-0.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.10_4_SDK.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.10_4_SDK.tiff
new file mode 100644
index 0000000..17748e5
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.10_4_SDK.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.tiff
new file mode 100644
index 0000000..2c1ddc7
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-1.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.10_4_SDK.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.10_4_SDK.tiff
new file mode 100644
index 0000000..294237a
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.10_4_SDK.tiff
diff --git a/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.tiff b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.tiff
new file mode 100644
index 0000000..b63ef59
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerAndLayoutTweakerTest4-2.tiff
diff --git a/AppKit/TestData/GTMUILocalizerWindow3State.gtmUTState b/AppKit/TestData/GTMUILocalizerWindow3State.gtmUTState
new file mode 100644
index 0000000..ed88b68
--- /dev/null
+++ b/AppKit/TestData/GTMUILocalizerWindow3State.gtmUTState
@@ -0,0 +1,304 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>$GTMArchive</key>
+	<string>GTMUnitTestingArchive</string>
+	<key>$GTMVersion</key>
+	<integer>1</integer>
+	<key>WindowContent</key>
+	<dict>
+		<key>ViewIsHidden</key>
+		<false/>
+		<key>ViewSubView 0</key>
+		<dict>
+			<key>BoxBorderType</key>
+			<integer>1</integer>
+			<key>BoxTitle</key>
+			<string>Localized Box</string>
+			<key>BoxTitlePosition</key>
+			<integer>2</integer>
+			<key>BoxType</key>
+			<integer>0</integer>
+			<key>ViewIsHidden</key>
+			<false/>
+			<key>ViewSubView 0</key>
+			<dict>
+				<key>ViewIsHidden</key>
+				<false/>
+				<key>ViewSubView 0</key>
+				<dict>
+					<key>ButtonAlternateTitle</key>
+					<string></string>
+					<key>ControlIsEnabled</key>
+					<true/>
+					<key>ControlSelectedCell</key>
+					<dict>
+						<key>CellState</key>
+						<integer>0</integer>
+						<key>CellTag</key>
+						<integer>0</integer>
+						<key>CellTitle</key>
+						<string>Localized Button</string>
+						<key>CellValue</key>
+						<string>0</string>
+					</dict>
+					<key>ControlTag</key>
+					<integer>0</integer>
+					<key>ControlType</key>
+					<string>NSButton</string>
+					<key>ControlValue</key>
+					<string>0</string>
+					<key>ViewIsHidden</key>
+					<false/>
+				</dict>
+				<key>ViewSubView 1</key>
+				<dict>
+					<key>ButtonAlternateTitle</key>
+					<string></string>
+					<key>ControlIsEnabled</key>
+					<true/>
+					<key>ControlSelectedCell</key>
+					<dict>
+						<key>CellState</key>
+						<integer>0</integer>
+						<key>CellTag</key>
+						<integer>0</integer>
+						<key>CellTitle</key>
+						<string>^Button2</string>
+						<key>CellValue</key>
+						<string>0</string>
+					</dict>
+					<key>ControlTag</key>
+					<integer>0</integer>
+					<key>ControlType</key>
+					<string>NSButton</string>
+					<key>ControlValue</key>
+					<string>0</string>
+					<key>ViewIsHidden</key>
+					<false/>
+				</dict>
+			</dict>
+		</dict>
+		<key>ViewSubView 1</key>
+		<dict>
+			<key>ViewIsHidden</key>
+			<false/>
+			<key>ViewSubView 0</key>
+			<dict>
+				<key>ViewIsHidden</key>
+				<false/>
+				<key>ViewSubView 0</key>
+				<dict>
+					<key>ViewIsHidden</key>
+					<false/>
+					<key>ViewSubView 0</key>
+					<dict>
+						<key>ControlIsEnabled</key>
+						<true/>
+						<key>ControlSelectedCell</key>
+						<dict>
+							<key>CellState</key>
+							<integer>0</integer>
+							<key>CellTag</key>
+							<integer>0</integer>
+							<key>CellTitle</key>
+							<string>Localized Label</string>
+							<key>CellValue</key>
+							<string>Localized Label</string>
+						</dict>
+						<key>ControlTag</key>
+						<integer>0</integer>
+						<key>ControlType</key>
+						<string>NSTextField</string>
+						<key>ControlValue</key>
+						<string>Localized Label</string>
+						<key>ViewIsHidden</key>
+						<false/>
+					</dict>
+					<key>ViewSubView 1</key>
+					<dict>
+						<key>ControlIsEnabled</key>
+						<true/>
+						<key>ControlSelectedCell</key>
+						<dict>
+							<key>CellState</key>
+							<integer>1</integer>
+							<key>CellTag</key>
+							<integer>1</integer>
+							<key>CellTitle</key>
+							<string>Localized Radio 1</string>
+							<key>CellValue</key>
+							<string>1</string>
+						</dict>
+						<key>ControlTag</key>
+						<integer>0</integer>
+						<key>ControlType</key>
+						<string>NSMatrix</string>
+						<key>ControlValue</key>
+						<string>1</string>
+						<key>MatrixAllowEmptySelection</key>
+						<false/>
+						<key>MatrixAutosizesCells</key>
+						<true/>
+						<key>MatrixCell 0</key>
+						<dict>
+							<key>CellState</key>
+							<integer>1</integer>
+							<key>CellTag</key>
+							<integer>1</integer>
+							<key>CellTitle</key>
+							<string>Localized Radio 1</string>
+							<key>CellValue</key>
+							<string>1</string>
+						</dict>
+						<key>MatrixCell 1</key>
+						<dict>
+							<key>CellState</key>
+							<integer>0</integer>
+							<key>CellTag</key>
+							<integer>0</integer>
+							<key>CellTitle</key>
+							<string>Localized Radio 2</string>
+							<key>CellValue</key>
+							<string>0</string>
+						</dict>
+						<key>MatrixCellPrototype</key>
+						<dict>
+							<key>CellState</key>
+							<integer>0</integer>
+							<key>CellTag</key>
+							<integer>0</integer>
+							<key>CellTitle</key>
+							<string>Radio</string>
+							<key>CellValue</key>
+							<string>0</string>
+						</dict>
+						<key>MatrixColumnCount</key>
+						<integer>1</integer>
+						<key>MatrixIntercellSpacing</key>
+						<string>{4, 2}</string>
+						<key>MatrixMode</key>
+						<integer>0</integer>
+						<key>MatrixRowCount</key>
+						<integer>2</integer>
+						<key>MatrixSelectionByRect</key>
+						<true/>
+						<key>ViewIsHidden</key>
+						<false/>
+					</dict>
+					<key>ViewSubView 2</key>
+					<dict>
+						<key>ControlIsEnabled</key>
+						<true/>
+						<key>ControlSelectedCell</key>
+						<dict>
+							<key>CellState</key>
+							<integer>0</integer>
+							<key>CellTag</key>
+							<integer>0</integer>
+							<key>CellTitle</key>
+							<string>^Label2</string>
+							<key>CellValue</key>
+							<string>^Label2</string>
+						</dict>
+						<key>ControlTag</key>
+						<integer>0</integer>
+						<key>ControlType</key>
+						<string>NSTextField</string>
+						<key>ControlValue</key>
+						<string>^Label2</string>
+						<key>ViewIsHidden</key>
+						<false/>
+					</dict>
+				</dict>
+			</dict>
+			<key>ViewSubView 1</key>
+			<dict>
+				<key>ControlIsEnabled</key>
+				<false/>
+				<key>ControlTag</key>
+				<integer>0</integer>
+				<key>ControlType</key>
+				<string>NSScroller</string>
+				<key>ViewIsHidden</key>
+				<false/>
+			</dict>
+			<key>ViewSubView 2</key>
+			<dict>
+				<key>ControlIsEnabled</key>
+				<false/>
+				<key>ControlTag</key>
+				<integer>0</integer>
+				<key>ControlType</key>
+				<string>NSScroller</string>
+				<key>ViewIsHidden</key>
+				<false/>
+			</dict>
+		</dict>
+		<key>ViewSubView 2</key>
+		<dict>
+			<key>ViewIsHidden</key>
+			<false/>
+			<key>ViewSubView 0</key>
+			<dict>
+				<key>ButtonAlternateTitle</key>
+				<string></string>
+				<key>ControlIsEnabled</key>
+				<true/>
+				<key>ControlSelectedCell</key>
+				<dict>
+					<key>CellState</key>
+					<integer>1</integer>
+					<key>CellTag</key>
+					<integer>0</integer>
+					<key>CellTitle</key>
+					<string>Localized Checkbox 1</string>
+					<key>CellValue</key>
+					<string>1</string>
+				</dict>
+				<key>ControlTag</key>
+				<integer>0</integer>
+				<key>ControlType</key>
+				<string>NSButton</string>
+				<key>ControlValue</key>
+				<string>1</string>
+				<key>ViewIsHidden</key>
+				<false/>
+			</dict>
+			<key>ViewSubView 1</key>
+			<dict>
+				<key>ButtonAlternateTitle</key>
+				<string></string>
+				<key>ControlIsEnabled</key>
+				<true/>
+				<key>ControlSelectedCell</key>
+				<dict>
+					<key>CellState</key>
+					<integer>1</integer>
+					<key>CellTag</key>
+					<integer>0</integer>
+					<key>CellTitle</key>
+					<string>Localized Checkbox 2</string>
+					<key>CellValue</key>
+					<string>1</string>
+				</dict>
+				<key>ControlTag</key>
+				<integer>0</integer>
+				<key>ControlType</key>
+				<string>NSButton</string>
+				<key>ControlValue</key>
+				<string>1</string>
+				<key>ViewIsHidden</key>
+				<false/>
+			</dict>
+		</dict>
+	</dict>
+	<key>WindowIsMain</key>
+	<false/>
+	<key>WindowIsVisible</key>
+	<false/>
+	<key>WindowTitle</key>
+	<string>Localized Window</string>
+</dict>
+</plist>
diff --git a/AppKit/TestData/Resources/English.lproj/Localizable.strings b/AppKit/TestData/Resources/English.lproj/Localizable.strings
index 4e6fabe..8228d3f 100644
--- a/AppKit/TestData/Resources/English.lproj/Localizable.strings
+++ b/AppKit/TestData/Resources/English.lproj/Localizable.strings
@@ -34,3 +34,4 @@
 "Checkbox 2" = "Localized Checkbox 2";
 "Radio 1" = "Localized Radio 1";
 "Radio 2" = "Localized Radio 2";
+"Box" = "Localized Box";