aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar dmaclach <dmaclach@gmail.com>2018-12-13 14:04:27 -0800
committerGravatar GitHub <noreply@github.com>2018-12-13 14:04:27 -0800
commitb947d97b47466c466da6add29385a8c60f2d4387 (patch)
tree33e6635d3ddcc4c22a52a6c34f79c6b3ffa8f975
parent543cc0cc845a5e1d76d9152ee9a112e5681d3f34 (diff)
We should not be generating position dependent code. This is no longer standard for macOS or iOS. (#225)
-rw-r--r--GTMiPhone.xcodeproj/project.pbxproj2
-rw-r--r--XcodeConfig/Target/LoadableBundle.xcconfig3
-rw-r--r--XcodeConfig/Target/SharedLibrary.xcconfig5
-rw-r--r--XcodeConfig/Target/StaticLibrary.xcconfig3
-rw-r--r--XcodeConfig/subconfig/General.xcconfig3
5 files changed, 1 insertions, 15 deletions
diff --git a/GTMiPhone.xcodeproj/project.pbxproj b/GTMiPhone.xcodeproj/project.pbxproj
index 6451d22..80a837d 100644
--- a/GTMiPhone.xcodeproj/project.pbxproj
+++ b/GTMiPhone.xcodeproj/project.pbxproj
@@ -767,7 +767,6 @@
GTM_EXTRA_WARNING_OVERRIDE_CFLAGS = "-Wno-unused-parameter";
GTM_HOST_GCC_PREPROCESSOR_DEFINITIONS = "GTM_USING_XCTEST=1";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
- LD_NO_PIE = YES;
ONLY_ACTIVE_ARCH = YES;
};
name = Debug;
@@ -811,7 +810,6 @@
GTM_EXTRA_WARNING_OVERRIDE_CFLAGS = "-Wno-unused-parameter";
GTM_HOST_GCC_PREPROCESSOR_DEFINITIONS = "GTM_USING_XCTEST=1";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
- LD_NO_PIE = YES;
};
name = Release;
};
diff --git a/XcodeConfig/Target/LoadableBundle.xcconfig b/XcodeConfig/Target/LoadableBundle.xcconfig
index 8b824d7..0b8e3d6 100644
--- a/XcodeConfig/Target/LoadableBundle.xcconfig
+++ b/XcodeConfig/Target/LoadableBundle.xcconfig
@@ -25,6 +25,3 @@
// Bundles should not have their external symbols stripped.
STRIP_STYLE = non-global
-
-// Bundles need to be position independent
-GCC_DYNAMIC_NO_PIC = NO
diff --git a/XcodeConfig/Target/SharedLibrary.xcconfig b/XcodeConfig/Target/SharedLibrary.xcconfig
index 7c37d50..9981d7b 100644
--- a/XcodeConfig/Target/SharedLibrary.xcconfig
+++ b/XcodeConfig/Target/SharedLibrary.xcconfig
@@ -22,8 +22,5 @@
// the License.
//
-// Dynamic libs need to be position independent
-GCC_DYNAMIC_NO_PIC = NO
-
// Dynamic libs should not have their external symbols stripped.
-STRIP_STYLE = non-global \ No newline at end of file
+STRIP_STYLE = non-global
diff --git a/XcodeConfig/Target/StaticLibrary.xcconfig b/XcodeConfig/Target/StaticLibrary.xcconfig
index df1016b..2e40943 100644
--- a/XcodeConfig/Target/StaticLibrary.xcconfig
+++ b/XcodeConfig/Target/StaticLibrary.xcconfig
@@ -22,9 +22,6 @@
// the License.
//
-// Static libs can be included in bundles so make them position independent
-GCC_DYNAMIC_NO_PIC = NO
-
// Static libs should not have their internal globals or external symbols
// stripped.
STRIP_STYLE = debugging
diff --git a/XcodeConfig/subconfig/General.xcconfig b/XcodeConfig/subconfig/General.xcconfig
index 1517514..59e60e6 100644
--- a/XcodeConfig/subconfig/General.xcconfig
+++ b/XcodeConfig/subconfig/General.xcconfig
@@ -48,9 +48,6 @@ GCC_ENABLE_OBJC_EXCEPTIONS = YES
// not sure why apple defaults this on, but it's pretty risky
ALWAYS_SEARCH_USER_PATHS = NO
-// Turn on position dependent code for most cases (overridden where appropriate)
-GCC_DYNAMIC_NO_PIC = YES
-
// For ObjC++ we want C++ cdtors called
GCC_OBJC_CALL_CXX_CDTORS = YES