summaryrefslogtreecommitdiff
path: root/doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment
blob: 76bd7045370c9190902fc46d789e1a521f303b79 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
[[!comment format=mdwn
 username="joey"
 subject="""comment 1"""
 date="2015-03-31T18:48:12Z"
 content="""
I think I didn't fully consider the `addurl --file` behavior when adding this
feature.

It seems to make sense for CLAIMURL to be used, since a special remote may
claim the url. It seems to make sense for CHECKURL to then be called (if
not --relaxed) to check that the url's content is present before adding it.

If CHECKURL-CONTENTS returns a file, it makes sense to check the file
size, but not use the suggested filename.

If CHECKURL-MULTI returns multiple files, I think it makes sense to give up
with an error.
"""]]