summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* Added a comment: Problems syncing with box.comGravatar tomas2013-05-19
|
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* Added a commentGravatar http://me.tinco.nl/2013-05-19
|
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* Added a commentGravatar http://joeyh.name/2013-05-19
|
* (no commit message)Gravatar GLITTAH2013-05-19
|
* (no commit message)Gravatar GLITTAH2013-05-19
|
* Merge branch 'master' of ssh://git-annex.branchable.comGravatar Joey Hess2013-05-19
|\
* | Switch to MonadCatchIO-transformers for better handling of state while ↵Gravatar Joey Hess2013-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | catching exceptions. As seen in this bug report, the lifted exception handling using the StateT monad throws away state changes when an action throws an exception. http://git-annex.branchable.com/bugs/git_annex_fork_bombs_on_gpg_file/ .. Which can result in cached values being redundantly calculated, or other possibly worse bugs when the annex state gets out of sync with reality. This switches from a StateT AnnexState to a ReaderT (MVar AnnexState). All changes to the state go via the MVar. So when an Annex action is running inside an exception handler, and it makes some changes, they immediately go into affect in the MVar. If it then throws an exception (or even crashes its thread!), the state changes are still in effect. The MonadCatchIO-transformers change is actually only incidental. I could have kept on using lifted-base for the exception handling. However, I'd have needed to write a new instance of MonadBaseControl for the new monad.. and I didn't write the old instance.. I begged Bas and he kindly sent it to me. Happily, MonadCatchIO-transformers is able to derive a MonadCatchIO instance for my monad. This is a deep level change. It passes the test suite! What could it break? Well.. The most likely breakage would be to code that runs an Annex action in an exception handler, and *wants* state changes to be thrown away. Perhaps the state changes leaves the state inconsistent, or wrong. Since there are relatively few places in git-annex that catch exceptions in the Annex monad, and the AnnexState is generally just used to cache calculated data, this is unlikely to be a problem. Oh yeah, this change also makes Assistant.Types.ThreadedMonad a bit redundant. It's now entirely possible to run concurrent Annex actions in different threads, all sharing access to the same state! The ThreadedMonad just adds some extra work on top of that, with its own MVar, and avoids such actions possibly stepping on one-another's toes. I have not gotten rid of it, but might try that later. Being able to run concurrent Annex actions would simplify parts of the Assistant code.
* | warningGravatar Joey Hess2013-05-19
| |
| * Added a commentGravatar http://joeyh.name/2013-05-19
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-19
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-19
| |
| * (no commit message)Gravatar http://me.tinco.nl/2013-05-19
| |
| * Added a comment: Not starting browser on Nexus 7, Android 4.2.2Gravatar https://www.google.com/accounts/o8/id?id=AItOawnu1NYw8UF-NoDbKu8YKVGxi8FoZLH7JPs2013-05-19
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-19
| |
| * Added a comment: GTalk/XMPPGravatar https://www.google.com/accounts/o8/id?id=AItOawmubB1Sj2rwFoVdZYvGV0ACaQUJQyiJXJI2013-05-19
| |
| * Added a commentGravatar https://www.google.com/accounts/o8/id?id=AItOawmUJBh1lYmvfCCiGr3yrdx-QhuLCSRnU5c2013-05-19
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-19
| |
| * Added a commentGravatar http://joeyh.name/2013-05-18
| |
* | print encryption setup message before actionGravatar Joey Hess2013-05-18
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-18
| |
| * Added a commentGravatar http://me.tinco.nl/2013-05-18
| |
| * (no commit message)Gravatar http://me.tinco.nl/2013-05-18
| |
| * (no commit message)Gravatar https://me.yahoo.com/a/BjlC7xlnk_b7HrB9HA0fHOnYSha7RhaYa.4-#acb552013-05-18
| |
| * TypoGravatar Richard Hartmann2013-05-18
|/ | | | Combed with extra fine teeth just to make Joey happy ;)
* Merge branch 'master' of ssh://git-annex.branchable.comGravatar Joey Hess2013-05-17
|\
| * Added a comment: Follow-up information on my systemGravatar http://yarikoptic.myopenid.com/2013-05-18
| |
* | ignore test suite failure until it has been gotten to work on windowsGravatar Joey Hess2013-05-17
| |
| * Fixed a typoGravatar https://www.google.com/accounts/o8/id?id=AItOawkGCmVc5qIJaQQgG82Hc5zzBdAVdhe2JEM2013-05-17
| |
| * Added a commentGravatar http://joeyh.name/2013-05-17
|/
* Merge branch 'master' of ssh://git-annex.branchable.comGravatar Joey Hess2013-05-17
|\
* | blog for the dayGravatar Joey Hess2013-05-17
| |
| * (no commit message)Gravatar https://www.google.com/accounts/o8/id?id=AItOawnSenxKyE_2Z6Wb-EBMO8FciyRywjx1ZiQ2013-05-17
|/
* clean up test dirGravatar Joey Hess2013-05-17
|
* run test suite in cygwin so it can find utilities etcGravatar Joey Hess2013-05-17
|
* better messageGravatar Joey Hess2013-05-17
|
* ssh warningsGravatar Joey Hess2013-05-17
|
* can't test gpg on Windows yetGravatar Joey Hess2013-05-17
|
* use posixcompatGravatar Joey Hess2013-05-17
|
* try building test suite on windowsGravatar Joey Hess2013-05-17
|
* updateGravatar Joey Hess2013-05-17
|
* run test suite on windows autobuilderGravatar Joey Hess2013-05-17
|
* improve handling of receiving object in direct mode when associated files ↵Gravatar Joey Hess2013-05-17
| | | | | | | | | | | | are modified Before, if a direct mode repo had one or more associated files that were modifed, moving the object into it would overwrite the associated files with the pristine object. Now, modified associated files are left unchanged. To ensure that, when an object is moved into a direct mode repo, it's not thrown away, it gets stored in indirect mode.
* fixGravatar Joey Hess2013-05-17
|
* store copy in inode cache tooGravatar Joey Hess2013-05-17
|
* test suite passes in direct modeGravatar Joey Hess2013-05-17
| | | | | | | | | | | This fixes a bug with git annex add in direct mode. If some files already existed in the tree pointing at the same key as a file that was just added, and their content was not present, add neglected to copy the content to those files. I also changed the behavior of moveAnnex slightly: When content is moved into the annex in direct mode, it does not overwrite any content already present in direct mode files. That content may be modified after all.
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-01 13:38:50 +0000