summaryrefslogtreecommitdiff
path: root/Utility
diff options
context:
space:
mode:
Diffstat (limited to 'Utility')
-rw-r--r--Utility/DirWatcher.hs14
-rw-r--r--Utility/INotify.hs13
-rw-r--r--Utility/Types/DirWatcher.hs3
3 files changed, 25 insertions, 5 deletions
diff --git a/Utility/DirWatcher.hs b/Utility/DirWatcher.hs
index 213aeb50a..e4ee83191 100644
--- a/Utility/DirWatcher.hs
+++ b/Utility/DirWatcher.hs
@@ -72,6 +72,20 @@ closingTracked = undefined
#endif
#endif
+/* With inotify, modifications to existing files can be tracked.
+ * Kqueue does not support this.
+ */
+modifyTracked :: Bool
+#if WITH_INOTIFY
+modifyTracked = True
+#else
+#if WITH_KQUEUE
+modifyTracked = False
+#else
+modifyTracked = undefined
+#endif
+#endif
+
/* Starts a watcher thread. The runStartup action is passed a scanner action
* to run, that will return once the initial directory scan is complete.
* Once runStartup returns, the watcher thread continues running,
diff --git a/Utility/INotify.hs b/Utility/INotify.hs
index 6af022819..7934c2446 100644
--- a/Utility/INotify.hs
+++ b/Utility/INotify.hs
@@ -38,9 +38,8 @@ import Control.Exception (throw)
- Note: Moving a file will cause events deleting it from its old location
- and adding it to the new location.
-
- - Note: Modification of files is not detected, and it's assumed that when
- - a file that was open for write is closed, it's finished being written
- - to, and can be added.
+ - Note: It's assumed that when a file that was open for write is closed,
+ - it's finished being written to, and can be added.
-
- Note: inotify has a limit to the number of watches allowed,
- /proc/sys/fs/inotify/max_user_watches (default 8192).
@@ -66,13 +65,16 @@ watchDir i dir ignored hooks
-- Select only inotify events required by the enabled
-- hooks, but always include Create so new directories can
-- be scanned.
- watchevents = Create : addevents ++ delevents
+ watchevents = Create : addevents ++ delevents ++ modifyevents
addevents
| hashook addHook || hashook addSymlinkHook = [MoveIn, CloseWrite]
| otherwise = []
delevents
| hashook delHook || hashook delDirHook = [MoveOut, Delete]
| otherwise = []
+ modifyevents
+ | hashook modifyHook = [Modify]
+ | otherwise = []
scan f = unless (ignored f) $ do
ms <- getstatus f
@@ -114,6 +116,9 @@ watchDir i dir ignored hooks
| otherwise = guarded $ runhook delHook f Nothing
where
guarded = unlessM (filetype (const True) f)
+ go (Modified { isDirectory = isd, maybeFilePath = Just f })
+ | isd = noop
+ | otherwise = runhook modifyHook f Nothing
go _ = noop
hashook h = isJust $ h hooks
diff --git a/Utility/Types/DirWatcher.hs b/Utility/Types/DirWatcher.hs
index ba7eae6a1..30ada9c68 100644
--- a/Utility/Types/DirWatcher.hs
+++ b/Utility/Types/DirWatcher.hs
@@ -19,7 +19,8 @@ data WatchHooks = WatchHooks
, delHook :: Hook FilePath
, delDirHook :: Hook FilePath
, errHook :: Hook String -- error message
+ , modifyHook :: Hook FilePath
}
mkWatchHooks :: WatchHooks
-mkWatchHooks = WatchHooks Nothing Nothing Nothing Nothing Nothing
+mkWatchHooks = WatchHooks Nothing Nothing Nothing Nothing Nothing Nothing