summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Command/ImportFeed.hs10
-rw-r--r--doc/bugs/YouTube_-_error_in_importfeed/comment_1_3c6a60ab9c772b95ca5205199554b914._comment16
2 files changed, 22 insertions, 4 deletions
diff --git a/Command/ImportFeed.hs b/Command/ImportFeed.hs
index 1736f2567..832ec1246 100644
--- a/Command/ImportFeed.hs
+++ b/Command/ImportFeed.hs
@@ -138,10 +138,12 @@ findDownloads u = go =<< downloadFeed u
Just $ ToDownload f u i $ Enclosure enclosureurl
Nothing -> mkquvi f i
mkquvi f i = case getItemLink i of
- Just link -> ifM (quviSupported link)
- ( return $ Just $ ToDownload f u i $ QuviLink link
- , return Nothing
- )
+ Just link -> do
+ liftIO $ print ("link", link)
+ ifM (quviSupported link)
+ ( return $ Just $ ToDownload f u i $ QuviLink link
+ , return Nothing
+ )
Nothing -> return Nothing
{- Feeds change, so a feed download cannot be resumed. -}
diff --git a/doc/bugs/YouTube_-_error_in_importfeed/comment_1_3c6a60ab9c772b95ca5205199554b914._comment b/doc/bugs/YouTube_-_error_in_importfeed/comment_1_3c6a60ab9c772b95ca5205199554b914._comment
new file mode 100644
index 000000000..afdff4942
--- /dev/null
+++ b/doc/bugs/YouTube_-_error_in_importfeed/comment_1_3c6a60ab9c772b95ca5205199554b914._comment
@@ -0,0 +1,16 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2016-12-19T19:55:23Z"
+ content="""
+It's somewhat misleading that it complains there are no enclosures in the
+feed. While importfeed mostly downloads only enclosures in podcast feeds,
+it also checks link tags, which this feed contains, to see if quvi supports
+downloading content from them. Quvi does support the links in this feed,
+so it should work despite there being no enclosures.
+
+I've reproduced it not working, and it seems that the problem is this is
+not quite a valid Atom feed, and the feed parsing library is failing to
+parse it. Perhaps that can be improved; I filed a bug here
+<https://github.com/bergmark/feed/issues/18>
+"""]]