summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorGravatar Joey Hess <joeyh@joeyh.name>2015-03-31 15:47:59 -0400
committerGravatar Joey Hess <joeyh@joeyh.name>2015-03-31 15:47:59 -0400
commitd48712de5b71579b3ff785adad023f4b17175ef5 (patch)
tree3afedc75241f095f278a7f574456573dc3fa1f39 /doc
parentcbd1a0c4921c6a32b1d665e205c57473d94fd5ef (diff)
forgot to add this comment
Diffstat (limited to 'doc')
-rw-r--r--doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment18
1 files changed, 18 insertions, 0 deletions
diff --git a/doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment b/doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment
new file mode 100644
index 000000000..76bd70453
--- /dev/null
+++ b/doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment
@@ -0,0 +1,18 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2015-03-31T18:48:12Z"
+ content="""
+I think I didn't fully consider the `addurl --file` behavior when adding this
+feature.
+
+It seems to make sense for CLAIMURL to be used, since a special remote may
+claim the url. It seems to make sense for CHECKURL to then be called (if
+not --relaxed) to check that the url's content is present before adding it.
+
+If CHECKURL-CONTENTS returns a file, it makes sense to check the file
+size, but not use the suggested filename.
+
+If CHECKURL-MULTI returns multiple files, I think it makes sense to give up
+with an error.
+"""]]