diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2015-03-26 14:02:35 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2015-03-26 14:02:35 -0400 |
| commit | e4c72d1a1e0dca1612ff1b24d5afd058d3adc9b6 (patch) | |
| tree | cb52ba10b7f698c1be71e2aa19b02c89d6e921d1 /doc | |
| parent | 8e377f1ea3471f7c0af3435ba801cb805bf646d2 (diff) | |
assistant: Committing a whole lot of files at once could overflow command-line length limits and cause the commit to fail. This only happened when using the assistant in an indirect mode repository.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn b/doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn index fd5242fdf..9fa44710c 100644 --- a/doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn +++ b/doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn @@ -8,3 +8,15 @@ long) </pre> Probably need to tune the command length limit for !linux. --[[Joey]] + +> Investigation suggests this is the problem: + + inRepo (Git.LsFiles.notInRepo False $ map changeFile pending) + +> If a lot of new files have been added, the `pending` list can be +> arbitrarily large, and this passes it to git ls-files as parameters.a +> +> It's not the actual commit that fails; that uses Git.Queue and xargs. +> --[[Joey]] + +>> [[fixed|done]] --[[Joey]] |