diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2017-05-11 17:33:18 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-05-11 17:36:03 -0400 |
| commit | a087841ae775a14197c1550488f54b5761f4700b (patch) | |
| tree | 93b0c8f09107395bd58f9dc7210b8ee0817cf20d /doc | |
| parent | b09ac870e1dd2bc924c2ab4cd1d2280024a8a80a (diff) | |
Ssh password prompting improved when using -J
When ssh connection caching is enabled (and when GIT_ANNEX_USE_GIT_SSH is
not set), only one ssh password prompt will be made per host, and only one
ssh password prompt will be made at a time.
This also fixes a race in prepSocket's stale ssh connection stopping
when run with -J. It was possible for one thread to start a cached ssh
connection, and another thread to immediately stop it, resulting in excess
connections being made.
This commit was supported by the NSF-funded DataLad project.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/bugs/get_-J_cannot_be_used_with_password-based_authentication/comment_6_f5fe8d4cecfceec5cb4a03dd054d2e0a._comment | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/doc/bugs/get_-J_cannot_be_used_with_password-based_authentication/comment_6_f5fe8d4cecfceec5cb4a03dd054d2e0a._comment b/doc/bugs/get_-J_cannot_be_used_with_password-based_authentication/comment_6_f5fe8d4cecfceec5cb4a03dd054d2e0a._comment index cd692ca40..2daef8727 100644 --- a/doc/bugs/get_-J_cannot_be_used_with_password-based_authentication/comment_6_f5fe8d4cecfceec5cb4a03dd054d2e0a._comment +++ b/doc/bugs/get_-J_cannot_be_used_with_password-based_authentication/comment_6_f5fe8d4cecfceec5cb4a03dd054d2e0a._comment @@ -37,9 +37,6 @@ non-concurrent uses the current, faster path. prepSocket takes a shared file level lock of the socket's lock file, which is used to tell when another git-annex process is using the connection multiplexer. -So, an optimisation would be for prepSocket to try to take a non-blocking -exclusive file-level lock. If it fails, it knows some process has -already taken the shared lock, and so the multiplexer is started and no -password prompting needs to be done. So it does not need to try to start -the multiplexer in this case. +So, an optimisation would be for prepSocket to check if it's already +taken that shared lock, and then it does not need to start the multiplexer. """]] |