diff options
| author |  Joey Hess <joey@kitenet.net> | 2012-10-11 12:58:03 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2012-10-11 12:58:24 -0400 |
| commit | 2b0dc0a1009b92a1c236598049b0efa623f9c25d (patch) | |
| tree | c98e9871f6b93c7370784c8ecd0b48cf687a7d9f /doc | |
| parent | ee6d02f8dbcd962db1666c06f701d3b0835b1ada (diff) | |
Avoid unsetting HOME when running certian git commands. Closes: #690193
Setting GIT_INDEX_FILE clobbers the rest of the environment, making git
not read ~/.gitconfig, and blow up if GECOS didn't have a name for the
user.
I'm not entirely happy with getEnvironment being run every time now,
that's somewhat expensive. It may make sense to just set GIT_COMMITTER_*
and GIT_AUTHOR_*, but I worry that clobbering the rest could break PATH,
or GIT_PATH, or something else that might be used by a command run in here.
And caching the environment is not a good idea either; it can change..
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/bugs/fatal:_empty_ident_name.mdwn | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/bugs/fatal:_empty_ident_name.mdwn b/doc/bugs/fatal:_empty_ident_name.mdwn index d2f44375f..241477287 100644 --- a/doc/bugs/fatal:_empty_ident_name.mdwn +++ b/doc/bugs/fatal:_empty_ident_name.mdwn @@ -46,3 +46,6 @@ commit 56c037c69e75def74d6ea90de8aa8a1954c52178 Arch Linux **Please provide any additional information below.** > [[done]] by adding name to the user, in /etc/passwd. --Stone + +>> Actually, [[done]] by avoiding clobbering HOME when running some git +>> commands. --[[Joey]] |