diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2015-09-09 17:02:00 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2015-09-09 17:02:00 -0400 |
| commit | 09b050b24597a21343f712e4bc7b6f8660113d63 (patch) | |
| tree | 508942f546882679c2f34648350f3579303eb856 /doc | |
| parent | eee2566fce1e3cf8337ced753a8dcfc2923b28b2 (diff) | |
fsck: Work around bug in persistent that broke display of problematically encoded filenames on stderr when using --incremental.
Diffstat (limited to 'doc')
2 files changed, 22 insertions, 0 deletions
diff --git a/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames.mdwn b/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames.mdwn index f4beac9fb..16acb005e 100644 --- a/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames.mdwn +++ b/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames.mdwn @@ -76,3 +76,5 @@ git-annex: fsck: 2 failed # End of transcript or log. """]] + +> [[fixed|done]] --[[Joey]] diff --git a/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames/comment_1_bb9cd3e753431b1f5dd8b94a1be4e4a3._comment b/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames/comment_1_bb9cd3e753431b1f5dd8b94a1be4e4a3._comment new file mode 100644 index 000000000..373c1e4e7 --- /dev/null +++ b/doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames/comment_1_bb9cd3e753431b1f5dd8b94a1be4e4a3._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-09-09T20:14:01Z" + content=""" +It only fails with --incremental, and the only difference +is that the fsck database is opened and written that way. + +Somehow, opening the database causes the encoding of the stderr handle to get +reset from the fileEncoding git-annex normally applies at startup to +the defaut, which crashes on filenames that don't use the locale's +encoding. + +What a strange side effect especially to find in haskell code! +It's some kind of bug in persistent that this happens. +I've filed a bug: <https://github.com/yesodweb/persistent/issues/474> + +I put in a workaround; I have it reset the encoding of the file handles +after opening the db. +"""]] |