diff options
| author |  https://www.google.com/accounts/o8/id?id=AItOawmkBwMWvNKZZCge_YqobCSILPMeK6xbFw8 <TobiasTheViking@web> | 2013-12-31 18:20:32 +0000 |
|---|---|---|
| committer |  admin <admin@branchable.com> | 2013-12-31 18:20:32 +0000 |
| commit | 8d25e7562b6dd97a8ef5f597462ce21bb7046859 (patch) | |
| tree | 736b168a50764fbc6357752c0113ea39fcf96c1e /doc/design/external_special_remote_protocol | |
| parent | f7afd04c83720c433a8a41b513463df5c0b35135 (diff) | |
Added a comment
Diffstat (limited to 'doc/design/external_special_remote_protocol')
| -rw-r--r-- | doc/design/external_special_remote_protocol/comment_7_edb649d0019a061ef7bf6534a444429d._comment | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/design/external_special_remote_protocol/comment_7_edb649d0019a061ef7bf6534a444429d._comment b/doc/design/external_special_remote_protocol/comment_7_edb649d0019a061ef7bf6534a444429d._comment new file mode 100644 index 000000000..4e9f91c42 --- /dev/null +++ b/doc/design/external_special_remote_protocol/comment_7_edb649d0019a061ef7bf6534a444429d._comment @@ -0,0 +1,16 @@ +[[!comment format=mdwn + username="https://www.google.com/accounts/o8/id?id=AItOawmkBwMWvNKZZCge_YqobCSILPMeK6xbFw8" + nickname="TobiasTheViking" + subject="comment 7" + date="2013-12-31T18:20:32Z" + content=""" +I think the hook running anything in shell, to interact with git annex, is a mistake. + +I see a lot more potential pitfalls and mistakes(especially crossplatform). + +It should be the existing git annex plumbing (preferred content) as you say. I just really think it should be configurable in the protocol, instead of a having to run a shell command. + +Since you have made this advanced protocol i really see it as a mistake to do anything between the hook and git-annex outside of the protocol, it makes much more sense to have all their interactions happen within the protocol. + +IMO anyways. +"""]] |