diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2017-12-06 13:16:06 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-12-06 13:22:31 -0400 |
| commit | 9ec6bdfb526fa6b75a264b6417b24aa7f01adc25 (patch) | |
| tree | fc6d7acac70a1835117e3f3c5296b71f1ebf7970 /doc/bugs | |
| parent | 30671447e071cee943701c8e9d72571ce2d6699d (diff) | |
fix regression in addurl --file caused by youtube-dl support
Now youtubeDlCheck downloads the beginning of the url's content and
checks if it's html, only when it is does it pass it off the youtube-dl
to check if it supports it.
This means more work is done for urls that youtube-dl does support,
but is probably more efficient for other urls, since it only downloads
the first chunk of content, while youtube-dl probably downloads more.
As well as the reported bug, this also fixes behavior when an url
was added with youtube-dl, but the url content has now changed from
a html page to something else. Remote.Web.checkKey used to wrongly
succeed in that situation, since youtube-dl said sure it can download
that something else.
This commit was supported by the NSF-funded DataLad project.
Diffstat (limited to 'doc/bugs')
| -rw-r--r-- | doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls.mdwn | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls.mdwn b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls.mdwn index 0dd86d57f..9c74c6aeb 100644 --- a/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls.mdwn +++ b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls.mdwn @@ -28,4 +28,4 @@ Some tests also failed related to our datalad archives git annex special remote [[!meta author=yoh]] - +> [[fixed|done]] --[[Joey]] |