uninit: Fix crash due to trying to write to deleted keys db.

Reversion introduced by v6 mode support, affects v5 too.

Also fix a similar crash when the webapp is used to delete a repository.

2 files changed, 22 insertions, 0 deletions

diff --git a/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error.mdwn b/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error.mdwn
index 1250061d6..cf779ab3d 100644
--- a/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error.mdwn
+++ b/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error.mdwn
@@ -1,3 +1,5 @@
+[[!meta title="git annex uninit causes SqlLite3 error"]]
+
 ### Please describe the problem.
 I am basically having issues with `git annex uninit`
 
@@ -74,3 +76,5 @@ Now if I add a local file I get a different error
 ### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
 
 I am super excited about what I can do with git-annex. I hope to setup and maintain encrypted repo(s) of some of my files, and access them by cloning a local copy of the encrypted repo and getting the files I want, using them, and then deleting the local copy.
+
+> [[fixed|done]] --[[Joey]]
diff --git a/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error/comment_1_be3aaa58fd3adfa5eeb893c205aa871c._comment b/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error/comment_1_be3aaa58fd3adfa5eeb893c205aa871c._comment
new file mode 100644
index 000000000..fed1699ac
--- /dev/null
+++ b/doc/bugs/git_uninit_on_OS_X_causes_SqlLite3_error/comment_1_be3aaa58fd3adfa5eeb893c205aa871c._comment
@@ -0,0 +1,18 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2016-07-12T17:48:50Z"
+ content="""
+Not OSX specific; reproduced on Linux.
+
+Instrumentation shows that removeInodeCaches is being called, when it
+unannexes the annexed file. This is why a file has to have been added to
+the repo to get the crash.
+
+It's actually not necessary for removeInodeCaches to be called in a v5
+repo, only in v6. If the code checked for v6 mode before writing to the
+database, such problems would be avoided except for in v6 mode.
+
+But, the actual fix is to make uninit close this and all other sqlite
+db's before deleting the .git/annex directory.
+"""]]