diff options
author | Joey Hess <joey@kitenet.net> | 2014-01-05 21:30:48 -0400 |
---|---|---|
committer | Joey Hess <joey@kitenet.net> | 2014-01-05 21:30:48 -0400 |
commit | 4cf6d95c1a9d10cb59669eaceafce4c7a3155eb6 (patch) | |
tree | 2ed9440dd31cb4cb925e9010bd54694b8c776519 /doc/bugs | |
parent | 5d305f1337e88ae7a07f54adc06c4a9d1d39f872 (diff) |
assistant: Fixed several minor memory leaks that manifested when adding a large number of files.
Diffstat (limited to 'doc/bugs')
-rw-r--r-- | doc/bugs/import_memleak_from_the_assistant.mdwn | 10 | ||||
-rw-r--r-- | doc/bugs/import_memleak_from_the_assistant/leakafter.png | bin | 0 -> 43348 bytes | |||
-rw-r--r-- | doc/bugs/import_memleak_from_the_assistant/leakbefore.png | bin | 0 -> 24006 bytes |
3 files changed, 10 insertions, 0 deletions
diff --git a/doc/bugs/import_memleak_from_the_assistant.mdwn b/doc/bugs/import_memleak_from_the_assistant.mdwn index 541d1707d..5a0a0225b 100644 --- a/doc/bugs/import_memleak_from_the_assistant.mdwn +++ b/doc/bugs/import_memleak_from_the_assistant.mdwn @@ -1596,3 +1596,13 @@ rsync error: error in rsync protocol data stream (code 12) at io.c(605) [sender= # End of transcript or log. """]] + +> [[Fixed|done]]. This was several garden-variety haskell laziness leaks, +> all fixed by adding strictness annotations. +> +> Before: [[leakbefore.png]] +> After: [[leakafter.png]] +> +> Looks like I got them all, and it returns to running in constant space +> after adding and uploading the files (which can take memory porportional +> to the number of files that were added/changed at once). --[[Joey]] diff --git a/doc/bugs/import_memleak_from_the_assistant/leakafter.png b/doc/bugs/import_memleak_from_the_assistant/leakafter.png Binary files differnew file mode 100644 index 000000000..32c27f370 --- /dev/null +++ b/doc/bugs/import_memleak_from_the_assistant/leakafter.png diff --git a/doc/bugs/import_memleak_from_the_assistant/leakbefore.png b/doc/bugs/import_memleak_from_the_assistant/leakbefore.png Binary files differnew file mode 100644 index 000000000..9a04bfb20 --- /dev/null +++ b/doc/bugs/import_memleak_from_the_assistant/leakbefore.png |