summaryrefslogtreecommitdiff
path: root/doc/bugs/direct_mode_renames.mdwn
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2013-02-06 12:40:59 -0400
committerGravatar Joey Hess <joey@kitenet.net>2013-02-06 12:44:19 -0400
commit48d59dbad11a2f99a0003f5f3bd93734429be11d (patch)
treeef74a5cb149d78c8dc3e74732ae52f5afb73f274 /doc/bugs/direct_mode_renames.mdwn
parent6be68947dcf80c99ed5135c1a968641dca199555 (diff)
pre-commit: Update direct mode mappings.
Making the pre-commit hook look at git diff-index to find changed direct mode files and update the mappings works pretty well. One case where it does not work is when a file is git annex added, and then git rmed, and then this is committed. That's a no-op commit, so the hook probably doesn't even run, and it certianly never notices that the file was deleted, so the mapping will still have the original filename in it. For this and other reasons, it's important that the mappings still be treated as possibly inconsistent. Also, the assistant now allows the pre-commit hook to run when in direct mode, so the mappings also get updated there.
Diffstat (limited to 'doc/bugs/direct_mode_renames.mdwn')
-rw-r--r--doc/bugs/direct_mode_renames.mdwn6
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/bugs/direct_mode_renames.mdwn b/doc/bugs/direct_mode_renames.mdwn
index d0c7a8b30..60f449300 100644
--- a/doc/bugs/direct_mode_renames.mdwn
+++ b/doc/bugs/direct_mode_renames.mdwn
@@ -8,6 +8,8 @@ file working properly in direct mode.
Perhaps the pre-commit hook needs to update the mapping for files that were
deleted or added.
-(This also affects moves of files when the assistant is being used.
+This also affects moves of files when the assistant is being used.
In this case, the assistant updates the mapping to add the new name,
-but does not delete the old name from the mapping.)
+but does not delete the old name from the mapping.
+
+> [[done]]; the pre-commit hook now updates the mappings. --[[Joey]]