diff options
| author |  Joey Hess <joey@kitenet.net> | 2013-09-19 16:30:37 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2013-09-19 16:41:21 -0400 |
| commit | 4aaa584eb632a981f5364c844f9293d4cdedaa65 (patch) | |
| tree | 082addc10fa1a1554a616d54bb8e41d03e94c074 /doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn | |
| parent | 5fddb08efccedd5c1542f5e16ec63a57498bc1f0 (diff) | |
more completely solve catKey memory leak
Done using a mode witness, which ensures it's fixed everywhere.
Fixing catFileKey was a bear, because git cat-file does not provide a
nice way to query for the mode of a file and there is no other efficient
way to do it. Oh, for libgit2..
Note that I am looking at tree objects from HEAD, rather than the index.
Because I cat-file cannot show a tree object for the index.
So this fix is technically incomplete. The only cases where it matters
are:
1. A new large file has been directly staged in git, but not committed.
2. A file that was committed to HEAD as a symlink has been staged
directly in the index.
This could be fixed a lot better using libgit2.
Diffstat (limited to 'doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn')
| -rw-r--r-- | doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn b/doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn index d63394b02..c127bac15 100644 --- a/doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn +++ b/doc/bugs/Out_of_memory_error_in_fsck_whereis_find_and_status_cmds.mdwn @@ -77,4 +77,8 @@ Any thoughts on how I can get git-annex (esp. fsck) to complete would be appreci Thanks Giovanni -[[!tag moreinfo]] +> [[fixed|done]]. However, if you saw this behavior, +> you have large files checked directly into git. You may +> want to examine your repository and use git filter-branch to clean +> it up. +> --[[Joey]] |