summaryrefslogtreecommitdiff
path: root/doc/bugs/CHECKPRESENT_could_check_file_size_as_well
diff options
context:
space:
mode:
authorGravatar http://joeyh.name/ <http://joeyh.name/@web>2015-01-06 17:41:45 +0000
committerGravatar admin <admin@branchable.com>2015-01-06 17:41:45 +0000
commitf3b5c6b4e95655a1e651689cfca77b23694a17e6 (patch)
tree19ce046ca55e148e4bc80647e2597f340e3fb579 /doc/bugs/CHECKPRESENT_could_check_file_size_as_well
parentb2e20f09400a67518042690b2c4e2a955eda44e8 (diff)
Added a comment
Diffstat (limited to 'doc/bugs/CHECKPRESENT_could_check_file_size_as_well')
-rw-r--r--doc/bugs/CHECKPRESENT_could_check_file_size_as_well/comment_1_7bbba896da745a8a6b69ec62bf71fc89._comment13
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/bugs/CHECKPRESENT_could_check_file_size_as_well/comment_1_7bbba896da745a8a6b69ec62bf71fc89._comment b/doc/bugs/CHECKPRESENT_could_check_file_size_as_well/comment_1_7bbba896da745a8a6b69ec62bf71fc89._comment
new file mode 100644
index 000000000..e917ec998
--- /dev/null
+++ b/doc/bugs/CHECKPRESENT_could_check_file_size_as_well/comment_1_7bbba896da745a8a6b69ec62bf71fc89._comment
@@ -0,0 +1,13 @@
+[[!comment format=mdwn
+ username="http://joeyh.name/"
+ subject="comment 1"
+ date="2015-01-06T17:41:45Z"
+ content="""
+The encrypted content size is not constant, and not known to git-annex.
+
+The only git-annex remote that checks the size in its checkpresent implementation is the web special remote, precisely because it's never encrypted. Also because files on the web change content from time to time and so that needs to be detected.
+
+What would make sense is to extend the reply to `CHECKPRESENT-SUCCESS Key [size]` or perhaps `CHECKPRESENT-SIZE Key size`. git-annex can then compare the value with the key's known size, if any. If the key is encrypted, it would need to skip this check.
+
+Note that chunk keys currently have their keySize inherited from the parent key, and the keyChunkSize of each chunk key is set to the key size. The last chunk of a key will typically be shorter than its keyChunkSize. That would need to be cleaned up.
+"""]]