diff options
| author |  Joey Hess <joey@kitenet.net> | 2012-09-20 17:24:40 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2012-09-20 17:24:40 -0400 |
| commit | 68ad7de4d00f9b33704e068b5eeb65514ccdecc4 (patch) | |
| tree | 0fabcab6a95929b60748398d746a6837354c9603 /Utility/Types | |
| parent | 06ed6ceac488384e87484a52f28e8a3c1750b1e6 (diff) | |
watch for changes to transfer info files, to update progress bars on upload
This is handled differently for inotify, which can track modifications of
existing files, and kqueue, which cannot (TTBOMK). On the inotify side,
the TransferWatcher just waits for the file to be updated and reads the new
bytesComplete. On the kqueue side, the TransferPoller has to re-read the
file every update (currently 0.5 seconds, might need to increase that).
I did think about working around kqueue's limitations by somehow creating
a new file each time the size changed. But cleaning up all the files that
would result seemed difficult. And really, this is not a lot worse than
the TransferWatcher's behavior for downloads, which stats a file every 0.5
seconds. As long as the OS has decent file caching behavior..
Diffstat (limited to 'Utility/Types')
| -rw-r--r-- | Utility/Types/DirWatcher.hs | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Utility/Types/DirWatcher.hs b/Utility/Types/DirWatcher.hs index ba7eae6a1..30ada9c68 100644 --- a/Utility/Types/DirWatcher.hs +++ b/Utility/Types/DirWatcher.hs @@ -19,7 +19,8 @@ data WatchHooks = WatchHooks , delHook :: Hook FilePath , delDirHook :: Hook FilePath , errHook :: Hook String -- error message + , modifyHook :: Hook FilePath } mkWatchHooks :: WatchHooks -mkWatchHooks = WatchHooks Nothing Nothing Nothing Nothing Nothing +mkWatchHooks = WatchHooks Nothing Nothing Nothing Nothing Nothing Nothing |