Fix space leak in fsck and drop commands.

The space leak was somehow caused by this line:

	absfiles <- mapM absPath files

I confess, I don't quite understand why this caused bad buffering,
but apparently the whole pipeline from git-ls-files backed up at that
point.

Happily, rewriting the code to only get the cwd once and use a pure
function to calculate absfiles clears it up, and should be a little more
efficient in syscalls too.

1 files changed, 8 insertions, 1 deletions

diff --git a/Utility.hs b/Utility.hs
index e63fa1f6b..8312335f8 100644
--- a/Utility.hs
+++ b/Utility.hs
@@ -12,6 +12,7 @@ module Utility (
 	readFileStrict,
 	parentDir,
 	absPath,
+	absPathFrom,
 	relPathCwdToDir,
 	relPathDirToDir,
 	boolSystem,
@@ -165,8 +166,14 @@ dirContains a b = a == b || a' == b' || (a'++"/") `isPrefixOf` b'
 absPath :: FilePath -> IO FilePath
 absPath file = do
 	cwd <- getCurrentDirectory
+	return $ absPathFrom cwd file
+
+{- Converts a filename into a normalized, absolute path
+ - from the specified cwd. -}
+absPathFrom :: FilePath -> FilePath -> FilePath
+absPathFrom cwd file =
 	case absNormPath cwd file of
-		Just f -> return f
+		Just f -> f
 		Nothing -> error $ "unable to normalize " ++ file
 
 {- Constructs a relative path from the CWD to a directory.