some reorg and further remote generalization

1 files changed, 19 insertions, 5 deletions

diff --git a/Remote.hs b/Remote.hs
index b3f1a0c6b..5508e0d12 100644
--- a/Remote.hs
+++ b/Remote.hs
@@ -25,20 +25,35 @@ module Remote (
 import Control.Monad.State (liftIO)
 import Control.Monad (when, liftM)
 import Data.List
+import Data.String.Utils
 
 import RemoteClass
 import qualified Remote.Git
-import qualified Remote.S3
+--import qualified Remote.S3
 import Types
 import UUID
 import qualified Annex
 import Trust
 import LocationLog
+import Messages
 
-{- add generators for new Remotes here -}
-generators :: [Annex [Remote Annex]]
+{- Add generators for new Remotes here. -}
+generators :: [Annex (RemoteGenerator Annex)]
 generators = [Remote.Git.generate]
 
+{- Runs a list of generators. -}
+runGenerators :: [Annex (RemoteGenerator Annex)] -> Annex [Remote Annex]
+runGenerators gs = do
+	(actions, expensive) <- collect ([], []) gs
+	when (not $ null expensive) $
+		showNote $ "getting UUID for " ++ join ", " expensive
+	sequence actions
+	where
+		collect v [] = return v
+		collect (actions, expensive) (x:xs) = do
+			(a, e) <- x
+			collect (a++actions, e++expensive) xs
+
 {- Builds a list of all available Remotes.
  - Since doing so can be expensive, the list is cached in the Annex. -}
 genList :: Annex [Remote Annex]
@@ -46,8 +61,7 @@ genList = do
 	rs <- Annex.getState Annex.remotes
 	if null rs
 		then do
-			lists <- sequence generators
-			let rs' = concat lists
+			rs' <- runGenerators generators
 			Annex.changeState $ \s -> s { Annex.remotes = rs' }
 			return rs'
 		else return rs