diff options
| author |  Joey Hess <joey@kitenet.net> | 2012-10-04 18:57:53 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2012-10-04 18:58:57 -0400 |
| commit | 076890be2be34ce91ca0d170f850a8ca2cce6ff8 (patch) | |
| tree | ccc71b8e12ea46cd18ea027204f25c37a31385de /Git | |
| parent | 743c35709de77055a3e4947d673219569cd57fb4 (diff) | |
remove now-unnecessary manual reaps
Diffstat (limited to 'Git')
| -rw-r--r-- | Git/Command.hs | 6 | ||||
| -rw-r--r-- | Git/HashObject.hs | 1 |
2 files changed, 5 insertions, 2 deletions
diff --git a/Git/Command.hs b/Git/Command.hs index 2e9562860..f38d6f72f 100644 --- a/Git/Command.hs +++ b/Git/Command.hs @@ -93,7 +93,11 @@ pipeNullSplit params repo = do pipeNullSplitZombie :: [CommandParam] -> Repo -> IO [String] pipeNullSplitZombie params repo = fst <$> pipeNullSplit params repo -{- Reaps any zombie git processes. -} +{- Reaps any zombie git processes. + - + - Warning: Not thread safe. Anything that was expecting to wait + - on a process and get back an exit status is going to be confused + - if this reap gets there first. -} reap :: IO () reap = do -- throws an exception when there are no child processes diff --git a/Git/HashObject.hs b/Git/HashObject.hs index 7d6b5cc19..e048ce8e5 100644 --- a/Git/HashObject.hs +++ b/Git/HashObject.hs @@ -39,7 +39,6 @@ hashFile h file = CoProcess.query h send receive hashObject :: ObjectType -> String -> Repo -> IO Sha hashObject objtype content repo = getSha subcmd $ do s <- pipeWriteRead (map Param params) content repo - reap -- XXX unsure why this is needed, of if it is anymore return s where subcmd = "hash-object" |