diff options
author | Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
---|---|---|
committer | Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
commit | 39c13f91004b41166b786785083e78b34df0c48f (patch) | |
tree | bf5ea0acf27c9075a63d3b23b970c3ea44ecee64 /Git/DiffTree.hs | |
parent | 3a9ca30fa8740a57ea477243498339f9738102d6 (diff) |
remove Params constructor from Utility.SafeCommand
This removes a bit of complexity, and should make things faster
(avoids tokenizing Params string), and probably involve less garbage
collection.
In a few places, it was useful to use Params to avoid needing a list,
but that is easily avoided.
Problems noticed while doing this conversion:
* Some uses of Params "oneword" which was entirely unnecessary
overhead.
* A few places that built up a list of parameters with ++
and then used Params to split it!
Test suite passes.
Diffstat (limited to 'Git/DiffTree.hs')
-rw-r--r-- | Git/DiffTree.hs | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/Git/DiffTree.hs b/Git/DiffTree.hs index 5dd4bde2d..fecc9307c 100644 --- a/Git/DiffTree.hs +++ b/Git/DiffTree.hs @@ -78,7 +78,13 @@ getdiff command params repo = do (diff, cleanup) <- pipeNullSplit ps repo return (parseDiffRaw diff, cleanup) where - ps = command : Params "-z --raw --no-renames -l0" : params + ps = + command : + Param "-z" : + Param "--raw" : + Param "--no-renames" : + Param "-l0" : + params {- Parses --raw output used by diff-tree and git-log. -} parseDiffRaw :: [String] -> [DiffTreeItem] |