diff options
author | 2012-10-04 18:04:09 -0400 | |
---|---|---|
committer | 2012-10-04 18:04:09 -0400 | |
commit | cedb6dc503441bfe54881ec646d86dd777635e7d (patch) | |
tree | 7643d8ca5248b750b99b7c6aeaea4205137127fc /Git/Command.hs | |
parent | 929f2a0df8f76caa21f94ea3afe8afc1d2dba14e (diff) |
make a pipeReadStrict, that properly waits on the process
Nearly everything that's reading from git is operating on a small
amount of output and has been switched to use that. Only pipeNullSplit
stuff continues using the lazy version that yields zombies.
Diffstat (limited to 'Git/Command.hs')
-rw-r--r-- | Git/Command.hs | 32 |
1 files changed, 24 insertions, 8 deletions
diff --git a/Git/Command.hs b/Git/Command.hs index 687f6802c..71579808b 100644 --- a/Git/Command.hs +++ b/Git/Command.hs @@ -43,14 +43,27 @@ run subcommand params repo = assertLocal repo $ - Note that this leaves the git process running, and so zombies will - result unless reap is called. -} -pipeRead :: [CommandParam] -> Repo -> IO String -pipeRead params repo = assertLocal repo $ +pipeReadLazy :: [CommandParam] -> Repo -> IO String +pipeReadLazy params repo = assertLocal repo $ withHandle StdoutHandle createBackgroundProcess p $ \h -> do fileEncoding h hGetContents h where - p = (proc "git" $ toCommand $ gitCommandLine params repo) - { env = gitEnv repo } + p = gitCreateProcess params repo + +{- Runs a git subcommand, and returns its output, strictly. + - + - Nonzero exit status is ignored. + -} +pipeReadStrict :: [CommandParam] -> Repo -> IO String +pipeReadStrict params repo = assertLocal repo $ + withHandle StdoutHandle (createProcessChecked ignoreFailureProcess) p $ \h -> do + fileEncoding h + output <- hGetContentsStrict h + hClose h + return output + where + p = gitCreateProcess params repo {- Runs a git subcommand, feeding it input, and returning its output, - which is expected to be fairly small, since it's all read into memory @@ -62,16 +75,19 @@ pipeWriteRead params s repo = assertLocal repo $ {- Runs a git subcommand, feeding it input on a handle with an action. -} pipeWrite :: [CommandParam] -> Repo -> (Handle -> IO ()) -> IO () -pipeWrite params repo = withHandle StdinHandle createProcessSuccess p - where - p = (proc "git" $ toCommand $ gitCommandLine params repo) +pipeWrite params repo = withHandle StdinHandle createProcessSuccess $ + gitCreateProcess params repo + +gitCreateProcess :: [CommandParam] -> Repo -> CreateProcess +gitCreateProcess params repo = + (proc "git" $ toCommand $ gitCommandLine params repo) { env = gitEnv repo } {- Reads null terminated output of a git command (as enabled by the -z - parameter), and splits it. -} pipeNullSplit :: [CommandParam] -> Repo -> IO [String] pipeNullSplit params repo = - filter (not . null) . split sep <$> pipeRead params repo + filter (not . null) . split sep <$> pipeReadLazy params repo where sep = "\0" |