diff options
author | Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
---|---|---|
committer | Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
commit | 39c13f91004b41166b786785083e78b34df0c48f (patch) | |
tree | bf5ea0acf27c9075a63d3b23b970c3ea44ecee64 /Git/CheckIgnore.hs | |
parent | 3a9ca30fa8740a57ea477243498339f9738102d6 (diff) |
remove Params constructor from Utility.SafeCommand
This removes a bit of complexity, and should make things faster
(avoids tokenizing Params string), and probably involve less garbage
collection.
In a few places, it was useful to use Params to avoid needing a list,
but that is easily avoided.
Problems noticed while doing this conversion:
* Some uses of Params "oneword" which was entirely unnecessary
overhead.
* A few places that built up a list of parameters with ++
and then used Params to split it!
Test suite passes.
Diffstat (limited to 'Git/CheckIgnore.hs')
-rw-r--r-- | Git/CheckIgnore.hs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/Git/CheckIgnore.hs b/Git/CheckIgnore.hs index a03f45432..322088f89 100644 --- a/Git/CheckIgnore.hs +++ b/Git/CheckIgnore.hs @@ -43,7 +43,10 @@ checkIgnoreStart repo = ifM supportedGitVersion where params = [ Param "check-ignore" - , Params "-z --stdin --verbose --non-matching" + , Param "-z" + , Param "--stdin" + , Param "--verbose" + , Param "--non-matching" ] repo' = repo { gitGlobalOpts = filter (not . pathspecs) (gitGlobalOpts repo) } pathspecs (Param "--literal-pathspecs") = True |