summaryrefslogtreecommitdiff
path: root/Git/CatFile.hs
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2013-05-31 12:20:17 -0400
committerGravatar Joey Hess <joey@kitenet.net>2013-05-31 12:42:13 -0400
commited73317dbdd1d822b1fbb15b249a330e453e6293 (patch)
treed3c792719b01583e2cc21a9a66f44a26a1d61bed /Git/CatFile.hs
parent8ca051c47ed0d326588ffb84203b4dc390b611cb (diff)
Can now restart certain long-running git processes if they crash, and continue working.
Fuzz tests have shown that git cat-file --batch sometimes stops running. It's not yet known why (no error message; repo seems ok). But this is something we can deal with in the CoProcess framework, since all 3 types of long-running git processes should be restartable if they fail. Note that, as implemented, only IO errors are caught. So an error thrown by the reveiver, when it sees something that is not valid output from git cat-file (etc) will not cause a restart. I don't want it to retry if git commands change their output or are just outputting garbage. This does mean that if the command did a partial output and crashed in the middle, it would still not be restarted. There is currently no guard against restarting a command repeatedly, if, for example, it crashes repeatedly on startup.
Diffstat (limited to 'Git/CatFile.hs')
-rw-r--r--Git/CatFile.hs2
1 files changed, 1 insertions, 1 deletions
diff --git a/Git/CatFile.hs b/Git/CatFile.hs
index 5ab10b187..d95972393 100644
--- a/Git/CatFile.hs
+++ b/Git/CatFile.hs
@@ -29,7 +29,7 @@ import qualified Utility.CoProcess as CoProcess
type CatFileHandle = CoProcess.CoProcessHandle
catFileStart :: Repo -> IO CatFileHandle
-catFileStart = CoProcess.rawMode <=< gitCoProcessStart
+catFileStart = CoProcess.rawMode <=< gitCoProcessStart True
[ Param "cat-file"
, Param "--batch"
]