diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2015-06-01 13:52:23 -0400 |
| commit | 39c13f91004b41166b786785083e78b34df0c48f (patch) | |
| tree | bf5ea0acf27c9075a63d3b23b970c3ea44ecee64 /Command/Log.hs | |
| parent | 3a9ca30fa8740a57ea477243498339f9738102d6 (diff) | |
remove Params constructor from Utility.SafeCommand
This removes a bit of complexity, and should make things faster
(avoids tokenizing Params string), and probably involve less garbage
collection.
In a few places, it was useful to use Params to avoid needing a list,
but that is easily avoided.
Problems noticed while doing this conversion:
* Some uses of Params "oneword" which was entirely unnecessary
overhead.
* A few places that built up a list of parameters with ++
and then used Params to split it!
Test suite passes.
Diffstat (limited to 'Command/Log.hs')
| -rw-r--r-- | Command/Log.hs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Command/Log.hs b/Command/Log.hs index 671c9d674..9ee7f8543 100644 --- a/Command/Log.hs +++ b/Command/Log.hs @@ -148,7 +148,11 @@ getLog key os = do config <- Annex.getGitConfig let logfile = p </> locationLogFile config key inRepo $ pipeNullSplitZombie $ - [ Params "log -z --pretty=format:%ct --raw --abbrev=40" + [ Param "log" + , Param "-z" + , Param "--pretty=format:%ct" + , Param "-raw" + , Param "--abbrev=40" , Param "--remove-empty" ] ++ os ++ [ Param $ Git.fromRef Annex.Branch.fullname |