diff options
| author |  Joey Hess <joey@kitenet.net> | 2012-02-13 23:42:44 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2012-02-13 23:52:21 -0400 |
| commit | cbaebf538a8659193fb3dbb4f32e0f918a385af3 (patch) | |
| tree | 63a86b6f3ffe8e08f8610a267c2c19bb2389bfc8 /Command/Get.hs | |
| parent | d35a8d85b5ee9ce3d6057300e21729183cce802b (diff) | |
rework git check-attr interface
Now gitattributes are looked up, efficiently, in only the places that
really need them, using the same approach used for cat-file.
The old CheckAttr code seemed very fragile, in the way it streamed files
through git check-attr.
I actually found that cad8824852aa0623dc41eac02a9e2bae47d88ec4
was still deadlocking with ghc 7.4, at the end of adding a lot of files.
This should fix that problem, and avoid future ones.
The best part is that this removes withAttrFilesInGit and withNumCopies,
which were complicated Seek methods, as well as simplfying the types
for several other Seek methods that had a Backend tupled in.
Diffstat (limited to 'Command/Get.hs')
| -rw-r--r-- | Command/Get.hs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Command/Get.hs b/Command/Get.hs index 5d032e13c..928ab0f1b 100644 --- a/Command/Get.hs +++ b/Command/Get.hs @@ -19,11 +19,11 @@ def = [withOptions [Command.Move.fromOption] $ command "get" paramPaths seek seek :: [CommandSeek] seek = [withField Command.Move.fromOption Remote.byName $ \from -> - withNumCopies $ \n -> whenAnnexed $ start from n] + withFilesInGit $ whenAnnexed $ start from] -start :: Maybe Remote -> Maybe Int -> FilePath -> (Key, Backend) -> CommandStart -start from numcopies file (key, _) = stopUnless (not <$> inAnnex key) $ - autoCopies key (<) numcopies $ do +start :: Maybe Remote -> FilePath -> (Key, Backend) -> CommandStart +start from file (key, _) = stopUnless (not <$> inAnnex key) $ + autoCopies file key (<) $ \_numcopies -> do case from of Nothing -> go $ perform key Just src -> do |