summaryrefslogtreecommitdiff
path: root/CmdLine
diff options
context:
space:
mode:
authorGravatar Joey Hess <joeyh@joeyh.name>2017-02-24 15:16:56 -0400
committerGravatar Joey Hess <joeyh@joeyh.name>2017-02-24 15:16:56 -0400
commit2f868db90c7ba16eee901b9b1472b1e1a889dd93 (patch)
tree8a366a36cc50cf1c3899aeaddf10e02d9cffc847 /CmdLine
parent13fb898fb2379a9ed9b7df2b645453059d296488 (diff)
add KeyVariety type
Where before the "name" of a key and a backend was a string, this makes it a concrete data type. This is groundwork for allowing some varieties of keys to be disabled in file2key, so git-annex won't use them at all. Benchmarks ran in my big repo: old git-annex info: real 0m3.338s user 0m3.124s sys 0m0.244s new git-annex info: real 0m3.216s user 0m3.024s sys 0m0.220s new git-annex find: real 0m7.138s user 0m6.924s sys 0m0.252s old git-annex find: real 0m7.433s user 0m7.240s sys 0m0.232s Surprising result; I'd have expected it to be slower since it now parses all the key varieties. But, the parser is very simple and perhaps sharing KeyVarieties uses less memory or something like that. This commit was supported by the NSF-funded DataLad project.
Diffstat (limited to 'CmdLine')
-rw-r--r--CmdLine/GitAnnex/Options.hs4
1 files changed, 3 insertions, 1 deletions
diff --git a/CmdLine/GitAnnex/Options.hs b/CmdLine/GitAnnex/Options.hs
index f0d00981b..f7e0dcf07 100644
--- a/CmdLine/GitAnnex/Options.hs
+++ b/CmdLine/GitAnnex/Options.hs
@@ -15,6 +15,7 @@ import Annex.Common
import qualified Git.Config
import qualified Git.Construct
import Git.Types
+import Types.Key
import Types.TrustLevel
import Types.NumCopies
import Types.Messages
@@ -346,4 +347,5 @@ completeRemotes = completer $ mkCompleter $ \input -> do
completeBackends :: HasCompleter f => Mod f a
-completeBackends = completeWith (map Backend.name Backend.list)
+completeBackends = completeWith $
+ map (formatKeyVariety . Backend.backendVariety) Backend.list