summaryrefslogtreecommitdiff
path: root/Checks.hs
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2012-06-04 17:32:46 -0400
committerGravatar Joey Hess <joey@kitenet.net>2012-06-04 18:09:18 -0400
commit5b4e5ce7e5141eac7f0bc81033d7d7676ff0008f (patch)
tree85ee183972451657f4a8b10cf9692da101dc8c9a /Checks.hs
parent659e6b13249ec9d8f3c01607b0eb819b8a5690fe (diff)
deletion
When a new file is annexed, a deletion event occurs when it's moved away to be replaced by a symlink. Most of the time, there is no problimatic race, because the same thread runs the add event as the deletion event. So, once the symlink is in place, the deletion code won't run at all, due to existing checks that a deleted file is really gone. But there is a race at startup, as then the inotify thread is running at the same time as the main thread, which does the initial tree walking and annexing. It would be possible for the deletion inotify to run in a perfect race with the addition, and remove the newly added symlink from the git cache. To solve this race, added event serialization via a MVar. We putMVar before running each event, which blocks if an event is already running. And when an event finishes (or crashes!), we takeMVar to free the lock. Also, make rm -rf not spew warnings by passing --ignore-unmatch when deleting directories.
Diffstat (limited to 'Checks.hs')
0 files changed, 0 insertions, 0 deletions