diff options
author | http://joeyh.name/ <http://joeyh.name/@web> | 2014-03-06 20:21:28 +0000 |
---|---|---|
committer | admin <admin@branchable.com> | 2014-03-06 20:21:28 +0000 |
commit | 0e1300ef3f71d264a0f0398a2b16deb50ba645eb (patch) | |
tree | f7629dd15aeb01eba2d04e5c1ccd1af93e4a23a2 | |
parent | 5a5f4f675ad8d12b798c37f0f2de2b804b272c31 (diff) |
Added a comment
-rw-r--r-- | doc/forum/copy_fails_for_some_fails_without_explanation/comment_8_884f31ce917c8e5ce9a32a55da9b42d6._comment | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/doc/forum/copy_fails_for_some_fails_without_explanation/comment_8_884f31ce917c8e5ce9a32a55da9b42d6._comment b/doc/forum/copy_fails_for_some_fails_without_explanation/comment_8_884f31ce917c8e5ce9a32a55da9b42d6._comment new file mode 100644 index 000000000..5ba7442dc --- /dev/null +++ b/doc/forum/copy_fails_for_some_fails_without_explanation/comment_8_884f31ce917c8e5ce9a32a55da9b42d6._comment @@ -0,0 +1,10 @@ +[[!comment format=mdwn + username="http://joeyh.name/" + ip="209.250.56.146" + subject="comment 8" + date="2014-03-06T20:21:16Z" + content=""" +Analysis: Remote.Git's onLocal calls Annex.new to make a new AnnexState for the local remote. This state is not cached, and is regenerated for each file. Since it runs a Annex.Branch check of the location log on the remote, it needs to start catFile, and since the state is not reused, a new CatFileHandle is allocated each time. I'm not sure, but there may have been a recent-ish change that caused the location log to get checked and so catfile to be run; the general inneficiency of making a new AnnexState each time is not new. + +Fixing this by caching the AnnexState will not only fix the resource leak, but should speed up local to local copies significantly! +"""]] |