diff options
| author |  http://joeyh.name/ <joey@web> | 2013-03-09 06:13:17 +0000 |
|---|---|---|
| committer |  admin <admin@branchable.com> | 2013-03-09 06:13:17 +0000 |
| commit | b06d2b562a1c134973d8331825683e9d89fc0716 (patch) | |
| tree | fcf6b4b95cf151b973b9bc8eb75d499a2bf4a924 | |
| parent | 60a9f676ef6dafa9eaf4f82389a3d40e098457e2 (diff) | |
Added a comment
| -rw-r--r-- | doc/bugs/git-annex-shell_doesn__39__t_honour_Rsync__39__s_bwlimit_option/comment_1_8cda861c11ef2fff3442e5a0df741939._comment | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/bugs/git-annex-shell_doesn__39__t_honour_Rsync__39__s_bwlimit_option/comment_1_8cda861c11ef2fff3442e5a0df741939._comment b/doc/bugs/git-annex-shell_doesn__39__t_honour_Rsync__39__s_bwlimit_option/comment_1_8cda861c11ef2fff3442e5a0df741939._comment new file mode 100644 index 000000000..8c82c7e36 --- /dev/null +++ b/doc/bugs/git-annex-shell_doesn__39__t_honour_Rsync__39__s_bwlimit_option/comment_1_8cda861c11ef2fff3442e5a0df741939._comment @@ -0,0 +1,12 @@ +[[!comment format=mdwn + username="http://joeyh.name/" + nickname="joey" + subject="comment 1" + date="2013-03-09T06:13:17Z" + content=""" +git-annex-shell cannot pass arbitrary rsync parameters through as specified by the client, because this would be a security hole (eg, allows overwriting or exposing arbitrary files). I'd have to pick out and whitelist safe parameters to make that work. + +I'm also not sure if rsync --server does anything with --bwlimit, it's more of a client side option. When rsync is connecting to a rsync:// server, it can't tell the server to run with --bwlimit, AFAIK. + +Also, the bwlimit option works by stalling the connection occasionally, it's hardly very good and you'll sometime see it ramp back to full speed in between stalls. +"""]] |