diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2017-10-25 15:04:55 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-10-25 15:04:55 -0400 |
| commit | 0b6dac2de037bb6cb00ebd81849a7adf62c2251d (patch) | |
| tree | 5aa69ebd5c87cc127091d42ce8bd06b5aa1fe401 | |
| parent | 458d578851e813430a0d1448a103569026a9bd9f (diff) | |
response
| -rw-r--r-- | doc/bugs/graft__47__graft_cleanup_commits_--_really_needed__63__/comment_1_7bc271ddeafc92d36d2b90fcb1481891._comment | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/doc/bugs/graft__47__graft_cleanup_commits_--_really_needed__63__/comment_1_7bc271ddeafc92d36d2b90fcb1481891._comment b/doc/bugs/graft__47__graft_cleanup_commits_--_really_needed__63__/comment_1_7bc271ddeafc92d36d2b90fcb1481891._comment new file mode 100644 index 000000000..8de4c1915 --- /dev/null +++ b/doc/bugs/graft__47__graft_cleanup_commits_--_really_needed__63__/comment_1_7bc271ddeafc92d36d2b90fcb1481891._comment @@ -0,0 +1,21 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-10-25T18:56:49Z" + content=""" +They're really needed. Squashing them together would make the tree ref +that's being grafted in not be reachable, so it would be subject to GC, +which would lose data that the export feature needs to make sure is +retained for later. + +It would be possible to squash the graft cleanup with the export.log update +commit. However, I was unable to stage the graft +into the git-annex branch index file using git update-index, due to +possibly a bug in git, so I was not able to find a way to do that. +See [[!commit 5483ea90eca33f61c799fb6a3c2675657caa9c75]] + +The diff makes it look somehow big and expensive, but the actual overhead +on disk is two commit objects. The tree object being grafted in is the +exported tree, so retaining it does not really add any overhead. So +something in the area of 2 kb overhead, per export of a tree. +"""]] |