diff options
author | http://joeyh.name/ <http://joeyh.name/@web> | 2014-05-28 22:31:21 +0000 |
---|---|---|
committer | admin <admin@branchable.com> | 2014-05-28 22:31:21 +0000 |
commit | f8fa1ef15aeaeff147cb9cb5cf25ef4edd1dcb4c (patch) | |
tree | 189fd4302d79a23160e476a96ea5dc0b02d30c64 | |
parent | 9f32b8476f280afcf1f1fa2d094fec59133448aa (diff) |
Added a comment
-rw-r--r-- | doc/bugs/Bootstrap3_icons_missing_on_Android/comment_12_a77477951576fc657d693811f11f9975._comment | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/doc/bugs/Bootstrap3_icons_missing_on_Android/comment_12_a77477951576fc657d693811f11f9975._comment b/doc/bugs/Bootstrap3_icons_missing_on_Android/comment_12_a77477951576fc657d693811f11f9975._comment new file mode 100644 index 000000000..23b523bbe --- /dev/null +++ b/doc/bugs/Bootstrap3_icons_missing_on_Android/comment_12_a77477951576fc657d693811f11f9975._comment @@ -0,0 +1,24 @@ +[[!comment format=mdwn + username="http://joeyh.name/" + ip="209.250.56.176" + subject="comment 12" + date="2014-05-28T22:31:21Z" + content=""" +The evilspliced data for eg, bootstrap.js omits that last byte. So presumably we overflow one byte and find a null (if we're lucky..). + +I checked the -ddump-splices output, and it omits that last newline! + +<pre> + \});\ + \\ + \})( jQuery );\"#), +</pre> + +Indeed, ghc omits any number of trailing newlines in this display. + +This is probably only recently a problem because of the wacky use of a unsafe bytestring + length that file-embed has started to do. Before, the newline was not included, but that's still valid JS. + +So, one fix would be to have the EvilSplicer rewrite the unsafePackAddressLen back to a regular bytestring construction. But this would need some tricky parsing (need to find the end of the string to remove the # from it). Alternatively, could remove trailing newlines from all the static js and css files. (Luckily none of the other static files end in a newline, and ghc is careful to preserve ending NULs etc). + +For now, I've removed the trailing newlines from the files. +"""]] |